chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js - Issue 2312353002: Revert of Add support for rich output inside of content editables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

Issue 2312353002: Revert of Add support for rich output inside of content editables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@editable_nav

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

index 65011670b96af423c7a0aa6d3ec300dad4d7d324..974e0a4f0d7313363085ca4bd8f2a114a191d849 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

@@ -140,8 +140,7 @@

if (!this.node)

return null;

- if (this.node.role == RoleType.inlineTextBox ||

- this.index_ == cursors.NODE_INDEX)

+ if (this.node.role == RoleType.inlineTextBox)

return this.node.parent;

return this.node;

@@ -166,7 +165,9 @@

sibling = sibling.previousSibling;

}

} else if (this.index_ == cursors.NODE_INDEX) {

- adjustedIndex = this.node.indexInParent + 1;

+ // Indicies of this kind are buggy. Set it to 0 (different than the DOM

+ // index in parent convention).

+ adjustedIndex = 0;

}

return adjustedIndex;