chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js - Issue 2312353002: Revert of Add support for rich output inside of content editables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2312353002: Revert of Add support for rich output inside of content editables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@editable_nav

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

index 02d966989a50b962a1ff0f135195dcc37c38f653..c7bc3d2f772897c702de244ce530495c7a045836 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

@@ -193,6 +193,12 @@

* @return {boolean}

AutomationPredicate.object = function(node) {

+ // Editable nodes are within a text-like field and don't make sense when

+ // performing object navigation. Users should use line, word, or character

+ // navigation. Only navigate to the top level node.

+ if (node.parent && node.parent.state.editable)

+ return false;

return node.state.focusable ||

(AutomationPredicate.leafOrStaticText(node) &&

(/\S+/.test(node.name) ||