Fix the bug related to reparent an item from folder which causes the folder item to be removed and …

We should not try to change folder view's UI state if it is hidden for reparenting. The crash happens due to the |activated_view_| in top level grid view is removed since the associated folder item is removed, but the |activated_view_| is not reset to NULL. To completely prevent the similar issue, we should also integrate calamity's r261571.

BUG=360887
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262876

[xiyuan, 2014-04-09 22:16:01]

lgtm

https://codereview.chromium.org/231233004/diff/1/ui/app_list/views/app_list_f...
File ui/app_list/views/app_list_folder_view.cc (right):

https://codereview.chromium.org/231233004/diff/1/ui/app_list/views/app_list_f...
ui/app_list/views/app_list_folder_view.cc:144: if (hide_for_reparent_ ||
layer()->opacity() == 0.0f)
Do we still need to test opacity?

[jennyz, 2014-04-09 22:24:48]

https://codereview.chromium.org/231233004/diff/1/ui/app_list/views/app_list_f...
File ui/app_list/views/app_list_folder_view.cc (right):

https://codereview.chromium.org/231233004/diff/1/ui/app_list/views/app_list_f...
ui/app_list/views/app_list_folder_view.cc:144: if (hide_for_reparent_ ||
layer()->opacity() == 0.0f)
On 2014/04/09 22:16:02, xiyuan wrote:
> Do we still need to test opacity?
The opacity test covers the case folder page is not show to user, only the top
level page is shown.

[jennyz, 2014-04-09 22:24:52]

The CQ bit was checked by jennyz@chromium.org

[commit-bot: I haz the power, 2014-04-09 22:25:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/231233004/1

[commit-bot: I haz the power, 2014-04-10 00:29:27]

Change committed as 262876