Fix the bug related to reparent an item from folder which causes the folder item to be removed and …

ui/app_list/views/app_list_folder_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_folder_view.h"
 
 #include <algorithm>
 
 #include "grit/ui_strings.h"
 #include "ui/accessibility/ax_view_state.h"
@@ skipping 123 matching lines @@
   return items_grid_view_->OnKeyPressed(event);
 }
 
 void AppListFolderView::OnAppListItemWillBeDeleted(AppListItem* item) {
   if (item == folder_item_) {
     items_grid_view_->OnFolderItemRemoved();
     folder_header_view_->OnFolderItemRemoved();
     folder_item_ = NULL;
 
     // Do not change state if it is hidden.
-    if (layer()->opacity() == 0.0f)
+    if (hide_for_reparent_ || layer()->opacity() == 0.0f)

[xiyuan, 2014/04/09 22:16:02]

Do we still need to test opacity?

[jennyz, 2014/04/09 22:24:49]

The opacity test covers the case folder page is not show to user, only the top
level page is shown. 

       return;
 
     // If the folder item associated with this view is removed from the model,
     // (e.g. the last item in the folder was deleted), reset the view and signal
     // the container view to show the app list instead.
     // Pass NULL to ShowApps() to avoid triggering animation from the deleted
     // folder.
     container_view_->ShowApps(NULL);
   }
 }
@@ skipping 160 matching lines @@
 void AppListFolderView::GiveBackFocusToSearchBox() {
   app_list_main_view_->search_box_view()->search_box()->RequestFocus();
 }
 
 void AppListFolderView::SetItemName(AppListFolderItem* item,
                                     const std::string& name) {
   model_->SetItemName(item, name);
 }
 
 }  // namespace app_list