ui/app_list/views/app_list_folder_view.cc - Issue 231233004: Fix the bug related to reparent an item from folder which causes the folder item to be removed and …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/views/app_list_folder_view.cc

Issue 231233004: Fix the bug related to reparent an item from folder which causes the folder item to be removed and … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/app_list/views/app_list_folder_view.cc

diff --git a/ui/app_list/views/app_list_folder_view.cc b/ui/app_list/views/app_list_folder_view.cc

index c7958406b6c0c54875b669c86d0049a0fb99028e..015f72c82137b897ba3808d7f2d55b4aa2b5a816 100644

--- a/ui/app_list/views/app_list_folder_view.cc

+++ b/ui/app_list/views/app_list_folder_view.cc

@@ -141,7 +141,7 @@ void AppListFolderView::OnAppListItemWillBeDeleted(AppListItem* item) {

folder_item_ = NULL;

// Do not change state if it is hidden.

- if (layer()->opacity() == 0.0f)

+ if (hide_for_reparent_ || layer()->opacity() == 0.0f)

xiyuan 2014/04/09 22:16:02 Do we still need to test opacity?

jennyz 2014/04/09 22:24:49 The opacity test covers the case folder page is no

return;

// If the folder item associated with this view is removed from the model,

« no previous file with comments | « no previous file | no next file » | no next file with comments »