Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2310623002: Remove GPU memory UMAs (Closed)

Created:
4 years, 3 months ago by ccameron
Modified:
4 years, 3 months ago
Reviewers:
rjkroege, dcheng, piman
CC:
chromium-reviews, rjkroege, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GPU memory UMAs Nobody is looking at them, and they're not even in histograms.xml The only thing GpuMemoryManager is doing now is populating the task manager values. BUG=643522 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23 Cr-Commit-Position: refs/heads/master@{#417233}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -127 lines) Patch
M content/browser/gpu/gpu_process_host.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 4 chunks +1 line, -24 lines 0 comments Download
M content/common/gpu_host_messages.h View 3 chunks +0 lines, -11 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D gpu/ipc/common/gpu_memory_uma_stats.h View 1 chunk +0 lines, -35 lines 0 comments Download
M gpu/ipc/common/memory_stats.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/ipc/common/memory_stats.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_manager_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/ipc/service/gpu_channel_test_common.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/ipc/service/gpu_memory_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/ipc/service/gpu_memory_manager.cc View 5 chunks +1 line, -24 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
ccameron
PTAL: Deletes dead code, doesn't do anything.
4 years, 3 months ago (2016-09-02 20:35:50 UTC) #3
rjkroege
lgtm
4 years, 3 months ago (2016-09-02 21:45:05 UTC) #4
piman
LGTM, thanks for the cleanup!
4 years, 3 months ago (2016-09-02 22:56:32 UTC) #7
dcheng
lgtm
4 years, 3 months ago (2016-09-02 23:00:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310623002/1
4 years, 3 months ago (2016-09-06 20:25:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/124274) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 3 months ago (2016-09-06 20:30:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310623002/20001
4 years, 3 months ago (2016-09-08 06:35:08 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 09:15:09 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:18:30 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da97274a9eaa10df5508e951d26c08e58ac38c23
Cr-Commit-Position: refs/heads/master@{#417233}

Powered by Google App Engine
This is Rietveld 408576698