Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2310473002: 🔟 Remove Parcelable -keep from base proguard rules (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, xunjieli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Parcelable -keep from base proguard rules And tidy up proguard_config -> proguard_preprocess_config rename Verified locally that ChromePublic.apk had no size change from this patch. BUG=640836 Committed: https://crrev.com/c41ec1ae1555bbb04c06f80a5fcbd86978e8735d Cr-Commit-Position: refs/heads/master@{#416428}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M base/android/base_proguard_config.flags View 1 chunk +3 lines, -6 lines 2 comments Download
M build/android/gyp/proguard.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
agrieve
On 2016/09/02 18:01:41, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:ianwen@chromium.org
4 years, 3 months ago (2016-09-02 18:01:50 UTC) #3
Ian Wen
lgtm https://codereview.chromium.org/2310473002/diff/1/base/android/base_proguard_config.flags File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2310473002/diff/1/base/android/base_proguard_config.flags#newcode46 base/android/base_proguard_config.flags:46: # If we annotated all Parcelables that get ...
4 years, 3 months ago (2016-09-02 20:25:54 UTC) #4
agrieve
https://codereview.chromium.org/2310473002/diff/1/base/android/base_proguard_config.flags File base/android/base_proguard_config.flags (right): https://codereview.chromium.org/2310473002/diff/1/base/android/base_proguard_config.flags#newcode46 base/android/base_proguard_config.flags:46: # If we annotated all Parcelables that get put ...
4 years, 3 months ago (2016-09-02 20:34:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310473002/1
4 years, 3 months ago (2016-09-02 20:35:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/286955)
4 years, 3 months ago (2016-09-02 22:48:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310473002/1
4 years, 3 months ago (2016-09-03 00:52:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-03 02:39:05 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-03 02:41:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c41ec1ae1555bbb04c06f80a5fcbd86978e8735d
Cr-Commit-Position: refs/heads/master@{#416428}

Powered by Google App Engine
This is Rietveld 408576698