Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: base/android/base_proguard_config.flags

Issue 2310473002: 🔟 Remove Parcelable -keep from base proguard rules (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/proguard.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/base_proguard_config.flags
diff --git a/base/android/base_proguard_config.flags b/base/android/base_proguard_config.flags
index 2775360d62a57b800c71c72b4c2026c74896cded..d3089d816495164f2d4ddfce78cc44a27b2fda92 100644
--- a/base/android/base_proguard_config.flags
+++ b/base/android/base_proguard_config.flags
@@ -43,14 +43,11 @@
}
# Don't obfuscate Parcelables as they might be marshalled outside Chrome.
+# If we annotated all Parcelables that get put into Bundles other than
Ian Wen 2016/09/02 20:25:54 The content of the new comment sounds like a TODO.
agrieve 2016/09/02 20:34:58 It's more of a NEVERDO I think :P
+# for saveInstanceState (e.g. PendingIntents), then we could actually keep the
+# names of just those ones. For now, we'll just keep them all.
-keepnames class * implements android.os.Parcelable
-# Keep all Parcelables, since Play Services has some that are used only by
-# reflection.
-# TODO(agrieve): Remove this once proguard flags provided by play services via
-# .aars are used. https://crbug.com/640836
--keep class * implements android.os.Parcelable
-
# Remove methods annotated with this if their return value is unused
-assumenosideeffects class ** {
@org.chromium.base.annotations.RemovableInRelease <methods>;
« no previous file with comments | « no previous file | build/android/gyp/proguard.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698