🔟 Remove Parcelable -keep from base proguard rules

base/android/base_proguard_config.flags

 # Keep line number information, useful for stack traces.
 -keepattributes SourceFile,LineNumberTable
 
 # Keep all annotation related attributes that can affect runtime
 -keepattributes RuntimeVisible*Annotations
 -keepattributes AnnotationDefault
 
 # Keep the annotations, because if we don't, the ProGuard rules that use them
 # will not be respected. These classes then show up in our final dex, which we
 # do not want - see crbug.com/628226.
@@ skipping 25 matching lines @@
 -keepclasseswithmembers,includedescriptorclasses class * {
   native <methods>;
 }
 
 # Keep all CREATOR fields within Parcelable that are kept.
 -keepclassmembers class * implements android.os.Parcelable {
   public static *** CREATOR;
 }
 
 # Don't obfuscate Parcelables as they might be marshalled outside Chrome.
+# If we annotated all Parcelables that get put into Bundles other than

[Ian Wen, 2016/09/02 20:25:54]

The content of the new comment sounds like a TODO. If we plan to improve this,
should we mark it as a TODO?

[agrieve, 2016/09/02 20:34:58]

It's more of a NEVERDO I think :P

+# for saveInstanceState (e.g. PendingIntents), then we could actually keep the
+# names of just those ones. For now, we'll just keep them all.
 -keepnames class * implements android.os.Parcelable
 
-# Keep all Parcelables, since Play Services has some that are used only by
-# reflection.
-# TODO(agrieve): Remove this once proguard flags provided by play services via
-#     .aars are used.  https://crbug.com/640836
--keep class * implements android.os.Parcelable
-
 # Remove methods annotated with this if their return value is unused
 -assumenosideeffects class ** {
   @org.chromium.base.annotations.RemovableInRelease <methods>;
 }
 
 # Keep all enum values and valueOf methods. See
 # http://proguard.sourceforge.net/index.html#manual/examples.html
 # for the reason for this. Also, see http://crbug.com/248037.
 -keepclassmembers enum * {
     public static **[] values();
 }