Removed polymer & mirror from Observatory

Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952

R=johnmccutchan@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/5177c2bca9ab2330267ca5bcfa373e1c4dc4c827

[cbernaschina, 2016-09-07 01:21:11]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[cbernaschina, 2016-09-07 17:03:41]

Description was changed from

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version
==========

to

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
==========

[Cutch, 2016-09-07 17:09:17]

Nice!

Some initial coments

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/view_model.dart:170: class TableTree {
is this being used anymore?

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/view_model.dart:291: class SortedTable {
can this code just be deleted now?

https://codereview.chromium.org/2310003004/diff/40001/runtime/observatory/pub...
File runtime/observatory/pubspec.yaml (right):

https://codereview.chromium.org/2310003004/diff/40001/runtime/observatory/pub...
runtime/observatory/pubspec.yaml:15: dart_to_js_script_rewriter: any
shouldn't dart_to_js_script_rewriter be in the dependency overrides section?

https://codereview.chromium.org/2310003004/diff/40001/tools/observatory_tool.py
File tools/observatory_tool.py (left):

https://codereview.chromium.org/2310003004/diff/40001/tools/observatory_tool....
tools/observatory_tool.py:24: 'main.*',
please double check that the deployed directory does not contain any large files
that we don't strictly need in deployed mode.

[rmacnak, 2016-09-07 17:19:49]

lgtm

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/allocation_profile.dart (right):

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/allocation_profile.dart:123: navBar([
All uses of navBar are over-indented.

[cbernaschina, 2016-09-07 17:27:54]

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/app/view_model.dart (right):

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/view_model.dart:170: class TableTree {
On 2016/09/07 17:09:17, Cutch wrote:
> is this being used anymore?

No.

Removed TableTree and TableTreeRow

Done

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/app/view_model.dart:291: class SortedTable {
On 2016/09/07 17:09:17, Cutch wrote:
> can this code just be deleted now?

It is still used by code-view

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/allocation_profile.dart (right):

https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/allocation_profile.dart:123: navBar([
On 2016/09/07 17:19:49, rmacnak wrote:
> All uses of navBar are over-indented.

Done.

https://codereview.chromium.org/2310003004/diff/40001/tools/observatory_tool.py
File tools/observatory_tool.py (left):

https://codereview.chromium.org/2310003004/diff/40001/tools/observatory_tool....
tools/observatory_tool.py:24: 'main.*',
On 2016/09/07 17:09:17, Cutch wrote:
> please double check that the deployed directory does not contain any large
files
> that we don't strictly need in deployed mode.

The only main.* file is main.dart.js

[cbernaschina, 2016-09-07 17:51:52]

https://codereview.chromium.org/2310003004/diff/40001/runtime/observatory/pub...
File runtime/observatory/pubspec.yaml (right):

https://codereview.chromium.org/2310003004/diff/40001/runtime/observatory/pub...
runtime/observatory/pubspec.yaml:15: dart_to_js_script_rewriter: any
On 2016/09/07 17:09:17, Cutch wrote:
> shouldn't dart_to_js_script_rewriter be in the dependency overrides section?

Done.

[cbernaschina, 2016-09-07 18:09:00]

Description was changed from

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
==========

to

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
==========

[Cutch, 2016-09-07 19:12:52]

LGTM with some comments.

Also, check your navMenu label names I *think* there are a bunch of copy & paste
errors there.

Excellent job!

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/icdata_view.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/icdata_view.dart:115: navMenu('instance'),
ICData?

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/library_view.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/library_view.dart:145: navMenu('instance'),
library?

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/megamorphiccache_view.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/megamorphiccache_view.dart:122:
navMenu('object'),
megamorphic inline cache

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/service/object.dart:4370: }
so nice to see all the @observable, @reflectable, ObservableList, ObservableMap
artifacts go away.

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/pu...
File runtime/observatory/pubspec.yaml (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/pu...
runtime/observatory/pubspec.yaml:1: # Generated file DO NOT EDIT
Is this file still generated? It would be great to have this automatically
generated in the deps repository.

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/we...
File runtime/observatory/web/main.dart (left):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/we...
runtime/observatory/web/main.dart:13: if (rec.level == Level.WARNING &&
You can remove this suppression conditional now that we don't use polymer
anymore!

[cbernaschina, 2016-09-07 19:45:41]

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/icdata_view.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/icdata_view.dart:115: navMenu('instance'),
On 2016/09/07 19:12:51, Cutch wrote:
> ICData?

Done.

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/library_view.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/library_view.dart:145: navMenu('instance'),
On 2016/09/07 19:12:52, Cutch wrote:
> library?

Done.

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/elements/megamorphiccache_view.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/elements/megamorphiccache_view.dart:122:
navMenu('object'),
On 2016/09/07 19:12:52, Cutch wrote:
> megamorphic inline cache

Done.

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/li...
runtime/observatory/lib/src/service/object.dart:4370: }
On 2016/09/07 19:12:52, Cutch wrote:
> so nice to see all the @observable, @reflectable, ObservableList,
ObservableMap
> artifacts go away.

Done.

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/we...
File runtime/observatory/web/main.dart (left):

https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/we...
runtime/observatory/web/main.dart:13: if (rec.level == Level.WARNING &&
On 2016/09/07 19:12:52, Cutch wrote:
> You can remove this suppression conditional now that we don't use polymer
> anymore!

Done.

[cbernaschina, 2016-09-07 21:13:07]

Description was changed from

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
==========

to

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952
==========

[cbernaschina, 2016-09-07 21:15:34]

Description was changed from

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952
==========

to

==========
Removed polymer & mirror from Observatory

web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952

R=johnmccutchan@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5177c2bca9ab2330267ca5bcfa373e1c4dc4c827
==========

[cbernaschina, 2016-09-07 21:15:36]

Committed patchset #10 (id:180001) manually as
5177c2bca9ab2330267ca5bcfa373e1c4dc4c827 (presubmit successful).