Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2310003004: Removed polymer & mirror from Observatory (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed polymer & mirror from Observatory web_components are still necessary, but avoiding to use shadow dom allows us to use the lite version Closes=https://github.com/dart-lang/sdk/issues/27239 Closes=https://github.com/dart-lang/sdk/issues/27148 Closes=https://github.com/dart-lang/sdk/issues/26952 R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5177c2bca9ab2330267ca5bcfa373e1c4dc4c827

Patch Set 1 #

Patch Set 2 : Fixed tests #

Total comments: 6

Patch Set 3 : Fixed menu > size #

Total comments: 4

Patch Set 4 : Addressed comments #

Patch Set 5 : Updated DEPS #

Patch Set 6 : Changed default sorting direction for Method in cpu-profile-table #

Total comments: 11

Patch Set 7 : Addressed main comments #

Patch Set 8 : Removed unnecessary files from build #

Patch Set 9 : Updated DEPS #

Patch Set 10 : Fixed crash in heap-map page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1430 lines, -5221 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/app.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.dart View 1 12 chunks +0 lines, -66 lines 0 comments Download
D runtime/observatory/lib/elements.html View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/observatory/lib/service.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/application.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/app/location_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 3 4 5 6 7 8 9 5 chunks +11 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/app/view_model.dart View 1 2 3 4 chunks +2 lines, -270 lines 0 comments Download
D runtime/observatory/lib/src/elements/action_link.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D runtime/observatory/lib/src/elements/action_link.html View 1 chunk +0 lines, -35 lines 0 comments Download
M runtime/observatory/lib/src/elements/allocation_profile.dart View 1 2 3 3 chunks +28 lines, -32 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/class_ref_as_value.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D runtime/observatory/lib/src/elements/class_ref_as_value.html View 1 chunk +0 lines, -30 lines 0 comments Download
D runtime/observatory/lib/src/elements/class_ref_wrapper.dart View 1 chunk +0 lines, -59 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_tree.dart View 1 2 3 3 chunks +9 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.dart View 1 2 3 5 chunks +27 lines, -30 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/code_ref_wrapper.dart View 1 chunk +0 lines, -63 lines 0 comments Download
M runtime/observatory/lib/src/elements/code_view.dart View 1 2 3 4 chunks +20 lines, -23 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/context_ref_wrapper.dart View 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 1 2 3 4 chunks +17 lines, -20 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 2 3 3 chunks +13 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile_table.dart View 1 2 3 4 5 6 chunks +16 lines, -20 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 24 chunks +216 lines, -133 lines 0 comments Download
M runtime/observatory/lib/src/elements/curly_block.dart View 1 6 chunks +19 lines, -27 lines 0 comments Download
D runtime/observatory/lib/src/elements/curly_block_wrapper.dart View 1 chunk +0 lines, -102 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 3 3 chunks +10 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_ref.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D runtime/observatory/lib/src/elements/error_ref_wrapper.dart View 1 chunk +0 lines, -65 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_view.dart View 1 2 3 2 chunks +6 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/eval_box_wrapper.dart View 1 chunk +0 lines, -143 lines 0 comments Download
D runtime/observatory/lib/src/elements/eval_link.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D runtime/observatory/lib/src/elements/eval_link.html View 1 chunk +0 lines, -33 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/field_ref_wrapper.dart View 1 chunk +0 lines, -61 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.dart View 1 4 chunks +4 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/flag_list.dart View 1 2 3 3 chunks +18 lines, -22 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/function_ref_wrapper.dart View 1 chunk +0 lines, -71 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.dart View 1 4 chunks +4 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/general_error.dart View 1 2 3 2 chunks +6 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.dart View 1 2 3 4 5 6 7 8 9 4 chunks +12 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 2 3 3 chunks +14 lines, -18 lines 0 comments Download
A runtime/observatory/lib/src/elements/helpers/nav_bar.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/helpers/nav_menu.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.dart View 1 2 3 4 5 6 3 chunks +15 lines, -19 lines 0 comments Download
M runtime/observatory/lib/src/elements/inbound_references.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 3 chunks +3 lines, -3 lines 0 comments Download
D runtime/observatory/lib/src/elements/instance_ref_wrapper.dart View 1 chunk +0 lines, -79 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.dart View 1 8 chunks +8 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_reconnect.dart View 1 2 3 2 chunks +6 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/isolate_ref_wrapper.dart View 1 chunk +0 lines, -64 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 1 2 3 5 chunks +22 lines, -24 lines 0 comments Download
M runtime/observatory/lib/src/elements/json_view.dart View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/library_ref_as_value.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D runtime/observatory/lib/src/elements/library_ref_as_value.html View 1 chunk +0 lines, -30 lines 0 comments Download
D runtime/observatory/lib/src/elements/library_ref_wrapper.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.dart View 1 2 3 4 5 6 8 chunks +21 lines, -23 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging.dart View 1 2 3 3 chunks +15 lines, -18 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging_list.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.dart View 1 2 3 4 5 6 3 chunks +15 lines, -18 lines 0 comments Download
M runtime/observatory/lib/src/elements/metrics.dart View 1 2 3 3 chunks +14 lines, -17 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/bar.dart View 1 1 chunk +0 lines, -76 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/class_menu.dart View 1 2 chunks +16 lines, -15 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/class_menu_wrapper.dart View 1 chunk +0 lines, -67 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/isolate_menu.dart View 1 2 chunks +37 lines, -42 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/isolate_menu_wrapper.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/library_menu.dart View 1 2 chunks +14 lines, -15 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/library_menu_wrapper.dart View 1 chunk +0 lines, -67 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/menu.dart View 1 1 chunk +0 lines, -115 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/menu_item.dart View 4 chunks +12 lines, -48 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/menu_item_wrapper.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/menu_wrapper.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/notify.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/notify_wrapper.dart View 1 chunk +0 lines, -131 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/refresh.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/refresh_wrapper.dart View 1 chunk +0 lines, -86 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/top_menu.dart View 1 2 chunks +17 lines, -20 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/top_menu_wrapper.dart View 1 chunk +0 lines, -58 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav/vm_menu.dart View 1 2 chunks +21 lines, -23 lines 0 comments Download
D runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart View 1 chunk +0 lines, -68 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/object_common_wrapper.dart View 1 chunk +0 lines, -112 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_view.dart View 1 2 3 3 chunks +15 lines, -18 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.dart View 1 2 3 3 chunks +15 lines, -18 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.dart View 1 2 3 3 chunks +9 lines, -11 lines 0 comments Download
D runtime/observatory/lib/src/elements/observatory_element.dart View 1 chunk +0 lines, -192 lines 0 comments Download
M runtime/observatory/lib/src/elements/pc_descriptors_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/persistent_handles.dart View 1 2 3 3 chunks +11 lines, -15 lines 0 comments Download
M runtime/observatory/lib/src/elements/ports.dart View 1 2 3 3 chunks +11 lines, -15 lines 0 comments Download
M runtime/observatory/lib/src/elements/retaining_path.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 2 chunks +1 line, -2 lines 0 comments Download
D runtime/observatory/lib/src/elements/script_inset_wrapper.dart View 1 chunk +0 lines, -266 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_ref.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/script_ref_wrapper.dart View 1 chunk +0 lines, -63 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.dart View 1 2 3 3 chunks +16 lines, -19 lines 0 comments Download
M runtime/observatory/lib/src/elements/sentinel_view.dart View 1 2 3 3 chunks +9 lines, -12 lines 0 comments Download
D runtime/observatory/lib/src/elements/service_ref.dart View 1 chunk +0 lines, -167 lines 0 comments Download
D runtime/observatory/lib/src/elements/service_ref.html View 1 chunk +0 lines, -6 lines 0 comments Download
D runtime/observatory/lib/src/elements/shims/binding.dart View 1 chunk +0 lines, -47 lines 0 comments Download
M runtime/observatory/lib/src/elements/source_inset.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/source_inset_wrapper.dart View 1 chunk +0 lines, -247 lines 0 comments Download
M runtime/observatory/lib/src/elements/source_link.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/lib/src/elements/source_link_wrapper.dart View 1 chunk +0 lines, -63 lines 0 comments Download
M runtime/observatory/lib/src/elements/strongly_reachable_instances.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.dart View 1 2 3 3 chunks +30 lines, -32 lines 0 comments Download
M runtime/observatory/lib/src/elements/top_retaining_instances.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/view_footer.dart View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_connect.dart View 1 2 3 3 chunks +6 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 1 2 3 3 chunks +11 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 5 6 79 chunks +379 lines, -411 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 5 chunks +2 lines, -40 lines 0 comments Download
M runtime/observatory/pubspec.yaml View 1 2 3 4 chunks +5 lines, -21 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/allocation_profile/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/class_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/class_tree/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/code_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/context_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/context_view/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/cpu_profile_table/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/curly_block/element_test.dart View 1 2 chunks +18 lines, -17 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/curly_block/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/error_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/error_view/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/field_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/flag_list/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/function_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/general_error/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/heap_snapshot/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/icdata_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/icdata_view/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/inbound_references/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/instance_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate/counter_chart/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate_reconnect/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/isolate_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/library_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/local_var_descriptor_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/megamorphiccache_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download
D runtime/observatory/tests/observatory_ui/nav/bar/element_test.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.dart View 1 3 chunks +6 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/library-menu/element_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/library-menu/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.dart View 1 3 chunks +12 lines, -11 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/tests/observatory_ui/nav/menu/element_test.dart View 1 1 chunk +0 lines, -74 lines 0 comments Download
D runtime/observatory/tests/observatory_ui/nav/menu/element_test.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/notify_exception/exception_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/refresh/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.dart View 1 1 chunk +0 lines, -58 lines 0 comments Download
D runtime/observatory/tests/observatory_ui/nav/top-menu/element_test.html View 1 1 chunk +0 lines, -20 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/nav/top_menu/element_test.dart View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/top_menu/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.dart View 1 4 chunks +7 lines, -10 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/object_common/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/objectpool_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/objectpool_view/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/objectstore_view/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/ports/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/retaining_path/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/script_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/sentinel_value/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/source_link/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/token_stream_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/unknown_ref/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/view_footer/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/web/index.html View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/observatory/web/main.dart View 1 2 3 4 5 6 1 chunk +0 lines, -12 lines 0 comments Download
M tools/observatory_tool.py View 1 2 3 4 5 6 7 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
cbernaschina
4 years, 3 months ago (2016-09-07 01:21:12 UTC) #2
cbernaschina
4 years, 3 months ago (2016-09-07 03:46:33 UTC) #3
Cutch
Nice! Some initial coments https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib/src/app/view_model.dart File runtime/observatory/lib/src/app/view_model.dart (right): https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib/src/app/view_model.dart#newcode170 runtime/observatory/lib/src/app/view_model.dart:170: class TableTree { is this ...
4 years, 3 months ago (2016-09-07 17:09:17 UTC) #5
rmacnak
lgtm https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib/src/elements/allocation_profile.dart File runtime/observatory/lib/src/elements/allocation_profile.dart (right): https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib/src/elements/allocation_profile.dart#newcode123 runtime/observatory/lib/src/elements/allocation_profile.dart:123: navBar([ All uses of navBar are over-indented.
4 years, 3 months ago (2016-09-07 17:19:49 UTC) #6
cbernaschina
https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib/src/app/view_model.dart File runtime/observatory/lib/src/app/view_model.dart (right): https://codereview.chromium.org/2310003004/diff/20001/runtime/observatory/lib/src/app/view_model.dart#newcode170 runtime/observatory/lib/src/app/view_model.dart:170: class TableTree { On 2016/09/07 17:09:17, Cutch wrote: > ...
4 years, 3 months ago (2016-09-07 17:27:54 UTC) #7
cbernaschina
https://codereview.chromium.org/2310003004/diff/40001/runtime/observatory/pubspec.yaml File runtime/observatory/pubspec.yaml (right): https://codereview.chromium.org/2310003004/diff/40001/runtime/observatory/pubspec.yaml#newcode15 runtime/observatory/pubspec.yaml:15: dart_to_js_script_rewriter: any On 2016/09/07 17:09:17, Cutch wrote: > shouldn't ...
4 years, 3 months ago (2016-09-07 17:51:52 UTC) #8
Cutch
LGTM with some comments. Also, check your navMenu label names I *think* there are a ...
4 years, 3 months ago (2016-09-07 19:12:52 UTC) #10
cbernaschina
https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/lib/src/elements/icdata_view.dart File runtime/observatory/lib/src/elements/icdata_view.dart (right): https://codereview.chromium.org/2310003004/diff/100001/runtime/observatory/lib/src/elements/icdata_view.dart#newcode115 runtime/observatory/lib/src/elements/icdata_view.dart:115: navMenu('instance'), On 2016/09/07 19:12:51, Cutch wrote: > ICData? Done. ...
4 years, 3 months ago (2016-09-07 19:45:41 UTC) #11
cbernaschina
4 years, 3 months ago (2016-09-07 21:15:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #10 (id:180001) manually as
5177c2bca9ab2330267ca5bcfa373e1c4dc4c827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698