runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart - Issue 2310003004: Removed polymer & mirror from Observatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart

Issue 2310003004: Removed polymer & mirror from Observatory (Closed)

Patch Set: Fixed crash in heap-map page Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/observatory_ui/nav/bar/element_test.html ('k') | runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart

diff --git a/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart

index 32fb9f0d7af1c6435b9299bdfdc32f9c66eccc84..c622dbe6c346e9736a6b31839b28298bab456623 100644

--- a/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart

+++ b/runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart

@@ -20,11 +20,12 @@ main() {

});

test('elements created after attachment', () async {

final e = new NavClassMenuElement(i_ref, c_ref);

+ e.content = [document.createElement('content')];

document.body.append(e);

await e.onRendered.first;

- expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');

+ expect(e.children.length, isNonZero, reason: 'has elements');

e.remove();

await e.onRendered.first;

- expect(e.shadowRoot.children.length, isZero, reason: 'is empty');

+ expect(e.children.length, isZero, reason: 'is empty');

});

}