Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2310003004: Removed polymer & mirror from Observatory (Closed)
Patch Set: Fixed crash in heap-map page Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index cdcb45716cd7e0864d4bc9967c0fef54ed25b118..600199cce3ea0219bdd064ef6b7a3145cd306100 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -48,11 +48,10 @@ RetainingPathRepository _retainingPathRepository
/// one page will be the current page. Pages are registered at startup.
/// When the user navigates within the application, each page is asked if it
/// can handle the current location, the first page to say yes, wins.
-abstract class Page extends Observable {
+abstract class Page {
final ObservatoryApplication app;
- final ObservableMap<String, String> internalArguments =
- new ObservableMap<String, String>();
- @observable HtmlElement element;
+ final Map<String, String> internalArguments = <String, String>{};
+ HtmlElement element;
Page(this.app);
@@ -458,8 +457,8 @@ class DebuggerPage extends MatchingPage {
@override
void onUninstall() {
- assert(element != null);
- element.children = const [];
+ super.onUninstall();
+ container.children = const [];
}
}
@@ -561,9 +560,11 @@ class AllocationProfilerPage extends MatchingPage {
app.startGCEventListener();
}
+ @override
void onUninstall() {
super.onUninstall();
app.stopGCEventListener();
+ container.children = const [];
}
}
@@ -673,6 +674,8 @@ class LoggingPage extends MatchingPage {
@override
void onUninstall() {
+ super.onUninstall();
+ container.children = const [];
app.stopLoggingEventListener();
}
@@ -780,7 +783,9 @@ class MetricsPage extends MatchingPage {
@override
void onUninstall() {
+ super.onUninstall();
_metricRepository.stopSampling(lastIsolate);
+ container.children = const [];
}
}
« no previous file with comments | « runtime/observatory/lib/src/app/location_manager.dart ('k') | runtime/observatory/lib/src/app/view_model.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698