Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2309873003: Extend PropertyHandle to include custom property identifiers (Closed)

Created:
4 years, 3 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend PropertyHandle to include custom property identifiers This change allows animation keyframes to hold custom property declaration values and treat them as individual properties. This is achieved by extending PropertyHandles to treat custom properties based on their string name rather than CSSPropertyID. This patch has no behavioural change as custom property animations are not applied yet and therefore not observable. This patch is a necessary step in supporting custom property animations. BUG=644148 Committed: https://crrev.com/294c014b805fae756af944846f9ef21a85a71d49 Cr-Commit-Position: refs/heads/master@{#422028}

Patch Set 1 #

Patch Set 2 : Make things not crash #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Patch Set 5 : Add unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -89 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthPairInterpolationType.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandle.h View 1 2 3 4 4 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandle.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyHandleTest.cpp View 1 2 3 4 2 chunks +40 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 2 3 4 4 chunks +33 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 3 4 4 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-09-29 09:36:24 UTC) #3
Eric Willigers
lgtm
4 years, 2 months ago (2016-09-29 22:34:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309873003/80001
4 years, 2 months ago (2016-09-30 00:20:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/270184)
4 years, 2 months ago (2016-09-30 00:30:17 UTC) #12
alancutter (OOO until 2018)
+timloh for StyleResolver comment review.
4 years, 2 months ago (2016-09-30 00:32:15 UTC) #14
Timothy Loh
On 2016/09/30 00:32:15, alancutter wrote: > +timloh for StyleResolver comment review. stamp lgtm
4 years, 2 months ago (2016-09-30 04:17:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309873003/80001
4 years, 2 months ago (2016-09-30 04:27:37 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-30 04:33:20 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 04:37:56 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/294c014b805fae756af944846f9ef21a85a71d49
Cr-Commit-Position: refs/heads/master@{#422028}

Powered by Google App Engine
This is Rietveld 408576698