third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp - Issue 2309873003: Extend PropertyHandle to include custom property identifiers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

Issue 2309873003: Extend PropertyHandle to include custom property identifiers (Closed)

Patch Set: Add unit tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

index b3e1f7ef53fc575cff833f4568f2d0b22395fc6b..0a5a6afda144ba7fd299cf015b869d7a8f3678a4 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

@@ -90,8 +90,8 @@ TEST_F(AnimationKeyframeEffectV8Test, CanCreateAnAnimation)

EXPECT_EQ(0, keyframes[0]->offset());

EXPECT_EQ(1, keyframes[1]->offset());

- const CSSValue& keyframe1Width = toStringKeyframe(keyframes[0].get())->cssPropertyValue(CSSPropertyWidth);

- const CSSValue& keyframe2Width = toStringKeyframe(keyframes[1].get())->cssPropertyValue(CSSPropertyWidth);

+ const CSSValue& keyframe1Width = toStringKeyframe(keyframes[0].get())->cssPropertyValue(PropertyHandle(CSSPropertyWidth));

+ const CSSValue& keyframe2Width = toStringKeyframe(keyframes[1].get())->cssPropertyValue(PropertyHandle(CSSPropertyWidth));

EXPECT_EQ("100px", keyframe1Width.cssText());

EXPECT_EQ("0px", keyframe2Width.cssText());