Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

Issue 2309873003: Extend PropertyHandle to include custom property identifiers (Closed)
Patch Set: Add unit tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
index efee1088b2d1538a71cbbfbbb2bc666c2589f82d..a422897c58ea9204ccc865b543ac33f15fc0545e 100644
--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp
@@ -32,6 +32,8 @@ static String removeSVGPrefix(const String& property)
CSSPropertyID AnimationInputHelpers::keyframeAttributeToCSSProperty(const String& property, const Document& document)
{
+ // TODO(crbug.com/644148): Allow custom properties that begin with "--".
+
// Disallow prefixed properties.
if (property[0] == '-' || isASCIIUpper(property[0]))
return CSSPropertyInvalid;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698