Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2309823002: [turbofan] put src/types.[h/cc] into src/compiler/types.[h/cc] (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] put src/types.[h/cc] into src/compiler/types.[h/cc] BUG= Committed: https://crrev.com/c30cc0722e05ca88f515d4d9c6ede91b9fe2570f Cr-Commit-Position: refs/heads/master@{#39181}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updates/comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -2006 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/access-info.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-operator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operation-typer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operation-typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/type-cache.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/compiler/types.h View 1 5 chunks +7 lines, -10 lines 0 comments Download
A + src/compiler/types.cc View 1 23 chunks +29 lines, -48 lines 0 comments Download
M src/property-details.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D src/types.h View 1 chunk +0 lines, -782 lines 0 comments Download
D src/types.cc View 1 chunk +0 lines, -1139 lines 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-representation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-types.cc View 1 3 chunks +2 lines, -1 line 0 comments Download
M test/cctest/types-fuzz.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/unittests/compiler/escape-analysis-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mvstanton
Hi Michael, Here is the file move we were talking 'bout. --Mike
4 years, 3 months ago (2016-09-05 14:17:03 UTC) #2
Michael Starzinger
LGTM. There are forward declaration in the following files. Can we also adapt them accordingly? ...
4 years, 3 months ago (2016-09-05 14:22:35 UTC) #3
mvstanton
Hi Michael, here are the updates, thx! --Mike https://codereview.chromium.org/2309823002/diff/1/test/cctest/test-field-type-tracking.cc File test/cctest/test-field-type-tracking.cc (right): https://codereview.chromium.org/2309823002/diff/1/test/cctest/test-field-type-tracking.cc#newcode21 test/cctest/test-field-type-tracking.cc:21: // ...
4 years, 3 months ago (2016-09-05 14:51:41 UTC) #4
Michael Starzinger
LGTM.
4 years, 3 months ago (2016-09-05 15:01:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309823002/20001
4 years, 3 months ago (2016-09-05 15:55:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-05 15:58:09 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 15:58:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c30cc0722e05ca88f515d4d9c6ede91b9fe2570f
Cr-Commit-Position: refs/heads/master@{#39181}

Powered by Google App Engine
This is Rietveld 408576698