Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2309773004: Layout tests: Use sRGB color space on Mac (Closed)

Created:
4 years, 3 months ago by ccameron
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, einbinder+watch-test-runner_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Layout tests: Use sRGB color space by default For historical and accidental reasons, different platforms use different color spaces for layout tests. Let's stop. This will break all Mac image layout tests. BUG=44872

Patch Set 1 #

Patch Set 2 : Only change Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -179 lines) Patch
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +1 line, -175 lines 0 comments Download

Depends on Patchset:

Issue 2299193005 Patch 20001

Messages

Total messages: 5 (5 generated)
ccameron
The CQ bit was checked by ccameron@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-06 19:15:41 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2309773004/20001
4 years, 3 months ago (2016-09-06 19:16:22 UTC) #2
ccameron
Description was changed from ========== Layout tests: Use sRGB color space by default This will ...
4 years, 3 months ago (2016-09-06 19:18:14 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-06 21:41:58 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 21:41:59 UTC) #5 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698