Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2299193005: Layout tests: Parameterize color space to use by default (Closed)

Created:
4 years, 3 months ago by ccameron
Modified:
4 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Layout tests: Parameterize color space to use by default Add an explicit sRGB ICC profile. This is a step towards moving all layout tests to the same sRGB color space. A follow-up patch delete the "generic RGB" color space and the #if block specifying different color spaces. BUG=44872 Committed: https://crrev.com/27978e43e0901a0ecb13833f9987ae9522e94d24 Cr-Commit-Position: refs/heads/master@{#416752}

Patch Set 1 #

Patch Set 2 : Leave behavior unchanged (for now) #

Patch Set 3 : Actually specify generic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+567 lines, -128 lines) Patch
M content/public/test/layouttest_support.h View 2 chunks +10 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 2 chunks +548 lines, -122 lines 0 comments Download
M ui/gfx/icc_profile.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (16 generated)
ccameron
This is just re-arranging things. The follow-up (https://codereview.chromium.org/2309773004/) will make Mac layout tests have the ...
4 years, 3 months ago (2016-09-06 20:05:56 UTC) #12
Avi (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-06 20:39:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299193005/40001
4 years, 3 months ago (2016-09-06 22:20:17 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-06 23:06:41 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:09:26 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/27978e43e0901a0ecb13833f9987ae9522e94d24
Cr-Commit-Position: refs/heads/master@{#416752}

Powered by Google App Engine
This is Rietveld 408576698