Use the URL passed to navigator.share().

Use the URL passed to navigator.share().

BUG=644034
Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Committed: https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806
Cr-Original-Commit-Position: refs/heads/master@{#417452}
Cr-Commit-Position: refs/heads/master@{#417546}

[Sam McNally, 2016-09-06 01:51:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 01:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 03:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 03:09:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sam McNally, 2016-09-06 03:12:41]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 03:12:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 03:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 03:45:44]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-09-06 03:54:15]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 03:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-06 04:01:20]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-09-06 04:11:43]

sammc@chromium.org changed reviewers:
+ mgiuca@chromium.org

[commit-bot: I haz the power, 2016-09-06 04:13:27]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2016-09-06 04:16:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 04:16:28]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-09-06 04:18:12]

lgtm with an optional nit to change tests.

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webshare/share-success.html (right):

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webshare/share-success.html:14:
mock.pushShareResult('the title', 'the message', getAbsoluteUrl(url), null);
Opinion: Don't use getAbsoluteURL, instead just hard-code the absolute URLs in
each case. It's longer, but it's more obvious exactly what the behaviour should
be (and therefore whether the tests are wrong).

[Matt Giuca, 2016-09-06 04:24:00]

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webshare/share-success.html (right):

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webshare/share-success.html:14:
mock.pushShareResult('the title', 'the message', getAbsoluteUrl(url), null);
On 2016/09/06 04:18:12, Matt Giuca wrote:
> Opinion: Don't use getAbsoluteURL, instead just hard-code the absolute URLs in
> each case. It's longer, but it's more obvious exactly what the behaviour
should
> be (and therefore whether the tests are wrong).

As discussed, too hard to predict what the URL will be (it's some random file://
URL in tests). Ignore.

[Sam McNally, 2016-09-06 04:34:15]

sammc@chromium.org changed reviewers:
+ dtrainor@chromium.org, mkwst@chromium.org

[Sam McNally, 2016-09-06 04:34:16]

+mkwst for third_party/WebKit

+dtrainor for chrome/android

[David Trainor- moved to gerrit, 2016-09-07 05:06:08]

chrome/android lgtm

[Sam McNally, 2016-09-08 00:17:28]

Description was changed from

==========
Use the URL passed to navigator.share().

BUG=644034
==========

to

==========
Use the URL passed to navigator.share().

BUG=644034
==========

[Sam McNally, 2016-09-08 00:17:28]

sammc@chromium.org changed reviewers:
- mkwst@chromium.org

[Sam McNally, 2016-09-08 00:22:53]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[Sam McNally, 2016-09-08 00:22:54]

-mkwst who is OOO
+esprehn for third_party/WebKit
+dcheng for the mojom

[dcheng, 2016-09-08 03:17:37]

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp (right):

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp:110:
shareData.hasURL() ? KURL(scriptState->getExecutionContext()->url(),
shareData.url()) : KURL(),
Should this be using doc->completeURL(shareData.url())?

[Sam McNally, 2016-09-08 03:23:53]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 03:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-08 03:32:05]

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp (right):

https://codereview.chromium.org/2309403002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp:110:
shareData.hasURL() ? KURL(scriptState->getExecutionContext()->url(),
shareData.url()) : KURL(),
On 2016/09/08 03:17:37, dcheng wrote:
> Should this be using doc->completeURL(shareData.url())?

Done.

[commit-bot: I haz the power, 2016-09-08 05:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 05:13:15]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-09-08 19:46:40]

mojom lgtm

[esprehn, 2016-09-08 22:44:30]

lgtm

[Sam McNally, 2016-09-09 00:27:25]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-09-09 00:27:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/2309403002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-09-09 00:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 00:35:43]

Description was changed from

==========
Use the URL passed to navigator.share().

BUG=644034
==========

to

==========
Use the URL passed to navigator.share().

BUG=644034
==========

[commit-bot: I haz the power, 2016-09-09 00:35:44]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-09 00:37:27]

Description was changed from

==========
Use the URL passed to navigator.share().

BUG=644034
==========

to

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}
==========

[commit-bot: I haz the power, 2016-09-09 00:37:30]

Patchset 2 (id:??) landed as
https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}

[shans, 2016-09-09 00:47:05]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2327713002/ by shans@chromium.org.

The reason for reverting is: Causing compile failure on Blimp Linux (dbg).

[jam, 2016-09-09 00:48:32]

A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/2321293002/ by jam@chromium.org.

The reason for reverting is: build failures
https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%2...

Looks like because of https://codereview.chromium.org/2250613002 which landed
after these try runs.

[findit-for-me, 2016-09-09 00:53:38]

FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 417452 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Sam McNally, 2016-09-09 01:50:36]

Description was changed from

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}
==========

to

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}
==========

[Sam McNally, 2016-09-09 01:52:42]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 01:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-09 03:24:03]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-09-09 03:24:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, esprehn@chromium.org, mgiuca@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2309403002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-09 03:24:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 05:52:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 05:52:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Matt Giuca, 2016-09-09 05:56:19]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-09-09 05:56:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 09:57:57]

Description was changed from

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}
==========

to

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}
==========

[commit-bot: I haz the power, 2016-09-09 09:57:59]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-09-09 09:59:33]

Description was changed from

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Cr-Commit-Position: refs/heads/master@{#417452}
==========

to

==========
Use the URL passed to navigator.share().

BUG=644034

Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
Committed: https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806
Cr-Original-Commit-Position: refs/heads/master@{#417452}
Cr-Commit-Position: refs/heads/master@{#417546}
==========

[commit-bot: I haz the power, 2016-09-09 09:59:34]

Patchset 3 (id:??) landed as
https://crrev.com/c9c1a3bf7f23a7f1fd3fcd4689351ea62a18c806
Cr-Commit-Position: refs/heads/master@{#417546}