Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2250613002: Rework use counter for navigator.share to use [MeasureAs]. (Closed)

Created:
4 years, 4 months ago by Matt Giuca
Modified:
4 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, chromium-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@webshare-usecounter
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rework use counter for navigator.share to use [MeasureAs]. Use automatic functionality instead of manually calling UseCounter::count. BUG=636288 Committed: https://crrev.com/e419b525a443f33ccc8315783ca7806b2ba8e63a Cr-Commit-Position: refs/heads/master@{#417228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.idl View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Matt Giuca
Should not affect functionality.
4 years, 3 months ago (2016-09-08 06:45:03 UTC) #2
esprehn
lgtm
4 years, 3 months ago (2016-09-08 07:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2250613002/1
4 years, 3 months ago (2016-09-08 07:26:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 09:10:32 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:11:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e419b525a443f33ccc8315783ca7806b2ba8e63a
Cr-Commit-Position: refs/heads/master@{#417228}

Powered by Google App Engine
This is Rietveld 408576698