Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java

Issue 2309403002: Use the URL passed to navigator.share(). (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
index e4c905b5efef4e98068a3e9cae9a5d4257b6a50f..df32f4f7592f4a3ba421fcab731ab7044ef528fe 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java
@@ -12,6 +12,7 @@ import org.chromium.chrome.browser.share.ShareHelper;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.browser.WebContents;
import org.chromium.mojo.system.MojoException;
+import org.chromium.mojom.url.mojom.Url;
import org.chromium.mojom.webshare.ShareService;
import org.chromium.ui.base.WindowAndroid;
@@ -33,7 +34,7 @@ public class ShareServiceImpl implements ShareService {
public void onConnectionError(MojoException e) {}
@Override
- public void share(String title, String text, final ShareResponse callback) {
+ public void share(String title, String text, Url url, final ShareResponse callback) {
if (mActivity == null) {
callback.call("Share failed");
return;
@@ -49,7 +50,7 @@ public class ShareServiceImpl implements ShareService {
}
};
- ShareHelper.share(false, false, mActivity, title, text, null, null, null, innerCallback);
+ ShareHelper.share(false, false, mActivity, title, text, url.url, null, null, innerCallback);
}
@Nullable
« no previous file with comments | « chrome/android/BUILD.gn ('k') | third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698