Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 23090007: Fix build/common.gypi to actually set proprietary_codecs when branding=Chrome. (Closed)

Created:
7 years, 4 months ago by scherkus (not reviewing)
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix build/common.gypi to actually set proprietary_codecs when branding=Chrome. The 'proprietary_codecs%': 0 declaration was overwriting the conditionally-set statement earlier in the file. Instead, move the 0 assignment into the else branch and copy the conditionally-set variable into the outer scope. I fail at gyp. BUG=277948 R=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M build/common.gypi View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
awong
LGTM
7 years, 4 months ago (2013-08-23 23:31:34 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
7 years, 4 months ago (2013-08-23 23:31:37 UTC) #2
scherkus (not reviewing)
7 years, 4 months ago (2013-08-23 23:33:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r219379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698