Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: build/common.gypi

Issue 23090007: Fix build/common.gypi to actually set proprietary_codecs when branding=Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index e70eaac88a8a245c7db3a48ac6d5494f4c0dd66a..8da93c5e0dafabcb727545d9d437506369b74f70 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -546,6 +546,8 @@
# proprietary codecs.
['OS=="android" or branding=="Chrome"', {
'proprietary_codecs%': 1,
+ }, {
+ 'proprietary_codecs%': 0,
}],
# Enable autofill dialog for Android, Mac and Views-enabled platforms.
@@ -882,6 +884,7 @@
'spdy_proxy_auth_value%': '<(spdy_proxy_auth_value)',
'enable_mdns%' : '<(enable_mdns)',
'v8_optimized_debug': '<(v8_optimized_debug)',
+ 'proprietary_codecs%': '<(proprietary_codecs)',
# Use system nspr instead of the bundled one.
'use_system_nspr%': 0,
@@ -941,10 +944,6 @@
# to ~/.gyp/include.gypi, gclient runhooks --force, and do a release build.
'win_use_allocator_shim%': 1, # 1 = shim allocator via libcmt; 0 = msvcrt
- # Whether proprietary audio/video codecs are assumed to be included with
- # this build (only meaningful if branding!=Chrome).
- 'proprietary_codecs%': 0,
-
# TODO(bradnelson): eliminate this when possible.
# To allow local gyp files to prevent release.vsprops from being included.
# Yes(1) means include release.vsprops.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698