Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: build/common.gypi

Issue 23090007: Fix build/common.gypi to actually set proprietary_codecs when branding=Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 }], 539 }],
540 ['OS=="android" and android_webview_build==1', { 540 ['OS=="android" and android_webview_build==1', {
541 'enable_printing%': 0, 541 'enable_printing%': 0,
542 }], 542 }],
543 543
544 # Android OS includes support for proprietary codecs regardless of 544 # Android OS includes support for proprietary codecs regardless of
545 # building Chromium or Google Chrome. We also ship Google Chrome with 545 # building Chromium or Google Chrome. We also ship Google Chrome with
546 # proprietary codecs. 546 # proprietary codecs.
547 ['OS=="android" or branding=="Chrome"', { 547 ['OS=="android" or branding=="Chrome"', {
548 'proprietary_codecs%': 1, 548 'proprietary_codecs%': 1,
549 }, {
550 'proprietary_codecs%': 0,
549 }], 551 }],
550 552
551 # Enable autofill dialog for Android, Mac and Views-enabled platforms. 553 # Enable autofill dialog for Android, Mac and Views-enabled platforms.
552 ['toolkit_views==1 or (OS=="android" and android_webview_build==0) or OS =="mac"', { 554 ['toolkit_views==1 or (OS=="android" and android_webview_build==0) or OS =="mac"', {
553 'enable_autofill_dialog%': 1 555 'enable_autofill_dialog%': 1
554 }], 556 }],
555 557
556 ['OS=="android" and android_webview_build==0', { 558 ['OS=="android" and android_webview_build==0', {
557 'enable_webrtc%': 1, 559 'enable_webrtc%': 1,
558 }], 560 }],
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 'google_default_client_id%': '<(google_default_client_id)', 877 'google_default_client_id%': '<(google_default_client_id)',
876 'google_default_client_secret%': '<(google_default_client_secret)', 878 'google_default_client_secret%': '<(google_default_client_secret)',
877 'enable_managed_users%': '<(enable_managed_users)', 879 'enable_managed_users%': '<(enable_managed_users)',
878 'native_discardable_memory%': '<(native_discardable_memory)', 880 'native_discardable_memory%': '<(native_discardable_memory)',
879 'native_memory_pressure_signals%': '<(native_memory_pressure_signals)', 881 'native_memory_pressure_signals%': '<(native_memory_pressure_signals)',
880 'spdy_proxy_auth_origin%': '<(spdy_proxy_auth_origin)', 882 'spdy_proxy_auth_origin%': '<(spdy_proxy_auth_origin)',
881 'spdy_proxy_auth_property%': '<(spdy_proxy_auth_property)', 883 'spdy_proxy_auth_property%': '<(spdy_proxy_auth_property)',
882 'spdy_proxy_auth_value%': '<(spdy_proxy_auth_value)', 884 'spdy_proxy_auth_value%': '<(spdy_proxy_auth_value)',
883 'enable_mdns%' : '<(enable_mdns)', 885 'enable_mdns%' : '<(enable_mdns)',
884 'v8_optimized_debug': '<(v8_optimized_debug)', 886 'v8_optimized_debug': '<(v8_optimized_debug)',
887 'proprietary_codecs%': '<(proprietary_codecs)',
885 888
886 # Use system nspr instead of the bundled one. 889 # Use system nspr instead of the bundled one.
887 'use_system_nspr%': 0, 890 'use_system_nspr%': 0,
888 891
889 # Use system protobuf instead of bundled one. 892 # Use system protobuf instead of bundled one.
890 'use_system_protobuf%': 0, 893 'use_system_protobuf%': 0,
891 894
892 # Use system yasm instead of bundled one. 895 # Use system yasm instead of bundled one.
893 'use_system_yasm%': 0, 896 'use_system_yasm%': 0,
894 897
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
934 'win_z7%' : 0, 937 'win_z7%' : 0,
935 938
936 # Although base/allocator lets you select a heap library via an 939 # Although base/allocator lets you select a heap library via an
937 # environment variable, the libcmt shim it uses sometimes gets in 940 # environment variable, the libcmt shim it uses sometimes gets in
938 # the way. To disable it entirely, and switch to normal msvcrt, do e.g. 941 # the way. To disable it entirely, and switch to normal msvcrt, do e.g.
939 # 'win_use_allocator_shim': 0, 942 # 'win_use_allocator_shim': 0,
940 # 'win_release_RuntimeLibrary': 2 943 # 'win_release_RuntimeLibrary': 2
941 # to ~/.gyp/include.gypi, gclient runhooks --force, and do a release build. 944 # to ~/.gyp/include.gypi, gclient runhooks --force, and do a release build.
942 'win_use_allocator_shim%': 1, # 1 = shim allocator via libcmt; 0 = msvcrt 945 'win_use_allocator_shim%': 1, # 1 = shim allocator via libcmt; 0 = msvcrt
943 946
944 # Whether proprietary audio/video codecs are assumed to be included with
945 # this build (only meaningful if branding!=Chrome).
946 'proprietary_codecs%': 0,
947
948 # TODO(bradnelson): eliminate this when possible. 947 # TODO(bradnelson): eliminate this when possible.
949 # To allow local gyp files to prevent release.vsprops from being included. 948 # To allow local gyp files to prevent release.vsprops from being included.
950 # Yes(1) means include release.vsprops. 949 # Yes(1) means include release.vsprops.
951 # Once all vsprops settings are migrated into gyp, this can go away. 950 # Once all vsprops settings are migrated into gyp, this can go away.
952 'msvs_use_common_release%': 1, 951 'msvs_use_common_release%': 1,
953 952
954 # TODO(bradnelson): eliminate this when possible. 953 # TODO(bradnelson): eliminate this when possible.
955 # To allow local gyp files to override additional linker options for msvs. 954 # To allow local gyp files to override additional linker options for msvs.
956 # Yes(1) means set use the common linker options. 955 # Yes(1) means set use the common linker options.
957 'msvs_use_common_linker_extras%': 1, 956 'msvs_use_common_linker_extras%': 1,
(...skipping 3766 matching lines...) Expand 10 before | Expand all | Expand 10 after
4724 # settings in target dicts. SYMROOT is a special case, because many other 4723 # settings in target dicts. SYMROOT is a special case, because many other
4725 # Xcode variables depend on it, including variables such as 4724 # Xcode variables depend on it, including variables such as
4726 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4725 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4727 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4726 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4728 # files to appear (when present) in the UI as actual files and not red 4727 # files to appear (when present) in the UI as actual files and not red
4729 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4728 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4730 # and therefore SYMROOT, needs to be set at the project level. 4729 # and therefore SYMROOT, needs to be set at the project level.
4731 'SYMROOT': '<(DEPTH)/xcodebuild', 4730 'SYMROOT': '<(DEPTH)/xcodebuild',
4732 }, 4731 },
4733 } 4732 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698