Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/version.gni

Issue 2308583002: version.gni: Pass |sources| after VERSION, BRANDING and LASTCHANGE (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/version.gni
diff --git a/chrome/version.gni b/chrome/version.gni
index a29cb8d372ec3c18f2976864b4df4dcc3b20c8eb..40b4a826b127d60d765cf7710bb1e7eeed5a6363 100644
--- a/chrome/version.gni
+++ b/chrome/version.gni
@@ -99,6 +99,14 @@ template("process_version") {
args += [ "--official" ]
}
+ args += [
+ "-f",
+ rebase_path(version_path, root_build_dir),
+ "-f",
+ rebase_path(branding_path, root_build_dir),
+ "-f",
+ rebase_path(lastchange_path, root_build_dir),
+ ]
if (defined(invoker.sources)) {
inputs += invoker.sources
foreach(i, invoker.sources) {
@@ -109,14 +117,6 @@ template("process_version") {
}
}
- args += [
- "-f",
- rebase_path(version_path, root_build_dir),
- "-f",
- rebase_path(branding_path, root_build_dir),
- "-f",
- rebase_path(lastchange_path, root_build_dir),
- ]
if (defined(invoker.extra_args)) {
args += invoker.extra_args
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698