version.gni: Pass |sources| after VERSION, BRANDING and LASTCHANGE

version.gni: Pass |sources| after VERSION, BRANDING and LASTCHANGE

This gives an opportunity for the files in |sources| to override the
values set in those 3 files that are always passed to version.py.

While this is not something used by Chromium itself at the moment, it
can be useful for downstreams who may need to process their own files
and do not want to reinvent the process_version() template.

R=dpranke@chromium.org,brettw@chromium.org,thestig@chromium.org

[Dirk Pranke, 2016-09-02 16:55:15]

It seems like it would make more sense for those parameters to be optionally
overridable, maybe?

[Raphael Kubo da Costa (rakuco), 2016-09-02 17:03:14]

Do you mean something along the lines of a new parameter like
|use_default_files|? Another option would be to move this to, say,
build/util/version.gni, make it more input-agnostic and adjust the callers.

[Dirk Pranke, 2016-09-02 17:08:53]

On 2016/09/02 17:03:14, Raphael Kubo da Costa (rakuco) wrote:
> Do you mean something along the lines of a new parameter like
> |use_default_files|? Another option would be to move this to, say,
> build/util/version.gni, make it more input-agnostic and adjust the callers.

Maybe that, or maybe pass in {version,branding,lastchange}_path vars directly?

Without seeing the calling context to see what the other args look like, it's
hard to
say what might be best.

[Raphael Kubo da Costa (rakuco), 2016-09-02 17:34:53]

I can see chrome/VERSION being used by quite a few process_version() callers,
but almost none of them need LASTCHANGE or BRANDING.

I'll try to work on a CL moving the file outside chrome/ and see how it goes.

[Raphael Kubo da Costa (rakuco), 2016-09-14 10:24:10]

On 2016/09/02 17:34:53, Raphael Kubo da Costa (rakuco) wrote:
> I can see chrome/VERSION being used by quite a few process_version() callers,
> but almost none of them need LASTCHANGE or BRANDING.
> 
> I'll try to work on a CL moving the file outside chrome/ and see how it goes.

This is being handled in https://codereview.chromium.org/2341673003/