Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Side by Side Diff: chrome/version.gni

Issue 2308583002: version.gni: Pass |sources| after VERSION, BRANDING and LASTCHANGE (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 6
7 # Runs the version processing script over the given template file to produce 7 # Runs the version processing script over the given template file to produce
8 # an output file. This is used for generating various forms of files that 8 # an output file. This is used for generating various forms of files that
9 # incorporate the product name and version. 9 # incorporate the product name and version.
10 # 10 #
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 outputs = [ 92 outputs = [
93 invoker.output, 93 invoker.output,
94 ] 94 ]
95 95
96 args = [] 96 args = []
97 97
98 if (is_official_build) { 98 if (is_official_build) {
99 args += [ "--official" ] 99 args += [ "--official" ]
100 } 100 }
101 101
102 args += [
103 "-f",
104 rebase_path(version_path, root_build_dir),
105 "-f",
106 rebase_path(branding_path, root_build_dir),
107 "-f",
108 rebase_path(lastchange_path, root_build_dir),
109 ]
102 if (defined(invoker.sources)) { 110 if (defined(invoker.sources)) {
103 inputs += invoker.sources 111 inputs += invoker.sources
104 foreach(i, invoker.sources) { 112 foreach(i, invoker.sources) {
105 args += [ 113 args += [
106 "-f", 114 "-f",
107 rebase_path(i, root_build_dir), 115 rebase_path(i, root_build_dir),
108 ] 116 ]
109 } 117 }
110 } 118 }
111 119
112 args += [
113 "-f",
114 rebase_path(version_path, root_build_dir),
115 "-f",
116 rebase_path(branding_path, root_build_dir),
117 "-f",
118 rebase_path(lastchange_path, root_build_dir),
119 ]
120 if (defined(invoker.extra_args)) { 120 if (defined(invoker.extra_args)) {
121 args += invoker.extra_args 121 args += invoker.extra_args
122 } 122 }
123 args += [ 123 args += [
124 "-o", 124 "-o",
125 rebase_path(invoker.output, root_build_dir), 125 rebase_path(invoker.output, root_build_dir),
126 ] 126 ]
127 if (defined(invoker.template_file)) { 127 if (defined(invoker.template_file)) {
128 args += [ rebase_path(invoker.template_file, root_build_dir) ] 128 args += [ rebase_path(invoker.template_file, root_build_dir) ]
129 } 129 }
(...skipping 14 matching lines...) Expand all
144 forward_variables_from(invoker, [ "visibility" ]) 144 forward_variables_from(invoker, [ "visibility" ])
145 sources = get_target_outputs(":$action_name") 145 sources = get_target_outputs(":$action_name")
146 public_deps = [ 146 public_deps = [
147 ":$action_name", 147 ":$action_name",
148 ] 148 ]
149 } 149 }
150 } 150 }
151 } 151 }
152 152
153 chrome_version_rc_template = "//chrome/app/chrome_version.rc.version" 153 chrome_version_rc_template = "//chrome/app/chrome_version.rc.version"
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698