Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 2308343002: Replaced PassRefPtr copites with moves in Source/modules. (Closed)

Created:
4 years, 3 months ago by Bugs Nash
Modified:
4 years, 3 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
aboxhall, aboxhall+watch_chromium.org, ajuma+watch-canvas_chromium.org, darktears, blink-reviews, blink-reviews-animation_chromium.org, Rik, chromium-reviews, cmumford, dmazzoni, dmazzoni+watch_chromium.org, dshwang, dtseng+watch_chromium.org, Eric Willigers, falken, horo+watch_chromium.org, je_julie, jsbell+idb_chromium.org, jsbell+serviceworker_chromium.org, Justin Novosad, kinuko+serviceworker, michaeln, nektarios, nektar+watch_chromium.org, nhiroki, rjwright, serviceworker-reviews, shans, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced PassRefPtr copites with moves in Source/modules. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG=640449 Committed: https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8 Cr-Commit-Position: refs/heads/master@{#416565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasPattern.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletGlobalScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBAny.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKey.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Bugs Nash
4 years, 3 months ago (2016-09-05 04:08:54 UTC) #4
Yuta Kitamura
LGTM +haraken for modules/ owners review
4 years, 3 months ago (2016-09-05 06:36:18 UTC) #8
haraken
LGTM
4 years, 3 months ago (2016-09-05 07:07:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308343002/1
4 years, 3 months ago (2016-09-05 22:58:51 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 23:02:32 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 23:04:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85df4ce3945fa1413d991881b1281802442c16a8
Cr-Commit-Position: refs/heads/master@{#416565}

Powered by Google App Engine
This is Rietveld 408576698