third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp - Issue 2308343002: Replaced PassRefPtr copites with moves in Source/modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

Issue 2308343002: Replaced PassRefPtr copites with moves in Source/modules. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp ('k') | third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

index c403fce62ed701cd3173c1e62b583403de941570..950d75f4dbb213f5ccd6d9a8e0572f85538af6b4 100644

--- a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

@@ -107,7 +107,7 @@ DocumentWebSocketChannel::BlobLoader::BlobLoader(PassRefPtr<BlobDataHandle> blob

: m_channel(channel)

, m_loader(FileReaderLoader::create(FileReaderLoader::ReadAsArrayBuffer, this))

{

- m_loader->start(channel->getExecutionContext(), blobDataHandle);

+ m_loader->start(channel->getExecutionContext(), std::move(blobDataHandle));

}

void DocumentWebSocketChannel::BlobLoader::cancel()

@@ -207,7 +207,7 @@ void DocumentWebSocketChannel::send(PassRefPtr<BlobDataHandle> blobDataHandle)

// Since Binary data are not displayed in Inspector, this does not

// affect actual behavior.

InspectorInstrumentation::didSendWebSocketFrame(document(), m_identifier, WebSocketFrame::OpCodeBinary, true, "", 0);

- m_messages.append(new Message(blobDataHandle));

+ m_messages.append(new Message(std::move(blobDataHandle)));

processSendQueue();

}