Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp

Issue 2308343002: Replaced PassRefPtr copites with moves in Source/modules. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/serviceworkers/ExtendableMessageEvent.h" 5 #include "modules/serviceworkers/ExtendableMessageEvent.h"
6 6
7 namespace blink { 7 namespace blink {
8 8
9 ExtendableMessageEvent* ExtendableMessageEvent::create(const AtomicString& type, const ExtendableMessageEventInit& initializer) 9 ExtendableMessageEvent* ExtendableMessageEvent::create(const AtomicString& type, const ExtendableMessageEventInit& initializer)
10 { 10 {
11 return new ExtendableMessageEvent(type, initializer); 11 return new ExtendableMessageEvent(type, initializer);
12 } 12 }
13 13
14 ExtendableMessageEvent* ExtendableMessageEvent::create(const AtomicString& type, const ExtendableMessageEventInit& initializer, WaitUntilObserver* observer) 14 ExtendableMessageEvent* ExtendableMessageEvent::create(const AtomicString& type, const ExtendableMessageEventInit& initializer, WaitUntilObserver* observer)
15 { 15 {
16 return new ExtendableMessageEvent(type, initializer, observer); 16 return new ExtendableMessageEvent(type, initializer, observer);
17 } 17 }
18 18
19 ExtendableMessageEvent* ExtendableMessageEvent::create(PassRefPtr<SerializedScri ptValue> data, const String& origin, MessagePortArray* ports, WaitUntilObserver* observer) 19 ExtendableMessageEvent* ExtendableMessageEvent::create(PassRefPtr<SerializedScri ptValue> data, const String& origin, MessagePortArray* ports, WaitUntilObserver* observer)
20 { 20 {
21 return new ExtendableMessageEvent(data, origin, ports, observer); 21 return new ExtendableMessageEvent(std::move(data), origin, ports, observer);
22 } 22 }
23 23
24 ExtendableMessageEvent* ExtendableMessageEvent::create(PassRefPtr<SerializedScri ptValue> data, const String& origin, MessagePortArray* ports, ServiceWorkerClien t* source, WaitUntilObserver* observer) 24 ExtendableMessageEvent* ExtendableMessageEvent::create(PassRefPtr<SerializedScri ptValue> data, const String& origin, MessagePortArray* ports, ServiceWorkerClien t* source, WaitUntilObserver* observer)
25 { 25 {
26 ExtendableMessageEvent* event = new ExtendableMessageEvent(data, origin, por ts, observer); 26 ExtendableMessageEvent* event = new ExtendableMessageEvent(std::move(data), origin, ports, observer);
27 event->m_sourceAsClient = source; 27 event->m_sourceAsClient = source;
28 return event; 28 return event;
29 } 29 }
30 30
31 ExtendableMessageEvent* ExtendableMessageEvent::create(PassRefPtr<SerializedScri ptValue> data, const String& origin, MessagePortArray* ports, ServiceWorker* sou rce, WaitUntilObserver* observer) 31 ExtendableMessageEvent* ExtendableMessageEvent::create(PassRefPtr<SerializedScri ptValue> data, const String& origin, MessagePortArray* ports, ServiceWorker* sou rce, WaitUntilObserver* observer)
32 { 32 {
33 ExtendableMessageEvent* event = new ExtendableMessageEvent(data, origin, por ts, observer); 33 ExtendableMessageEvent* event = new ExtendableMessageEvent(std::move(data), origin, ports, observer);
34 event->m_sourceAsServiceWorker = source; 34 event->m_sourceAsServiceWorker = source;
35 return event; 35 return event;
36 } 36 }
37 37
38 MessagePortArray ExtendableMessageEvent::ports(bool& isNull) const 38 MessagePortArray ExtendableMessageEvent::ports(bool& isNull) const
39 { 39 {
40 // TODO(bashi): Currently we return a copied array because the binding 40 // TODO(bashi): Currently we return a copied array because the binding
41 // layer could modify the content of the array while executing JS callbacks. 41 // layer could modify the content of the array while executing JS callbacks.
42 // Avoid copying once we can make sure that the binding layer won't 42 // Avoid copying once we can make sure that the binding layer won't
43 // modify the content. 43 // modify the content.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 , m_serializedData(data) 110 , m_serializedData(data)
111 , m_origin(origin) 111 , m_origin(origin)
112 , m_lastEventId(String()) 112 , m_lastEventId(String())
113 , m_ports(ports) 113 , m_ports(ports)
114 { 114 {
115 if (m_serializedData) 115 if (m_serializedData)
116 m_serializedData->registerMemoryAllocatedWithCurrentScriptContext(); 116 m_serializedData->registerMemoryAllocatedWithCurrentScriptContext();
117 } 117 }
118 118
119 } // namespace blink 119 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698