Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chromecast/base/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_elf/BUILD.gn ('k') | chromecast/crypto/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/BUILD.gn
diff --git a/chromecast/base/BUILD.gn b/chromecast/base/BUILD.gn
index f24bb2c590b56a8bd9f4e336ddf82cadba251ba3..a757d3b01072f7167f788d336eb120945cfe82b1 100644
--- a/chromecast/base/BUILD.gn
+++ b/chromecast/base/BUILD.gn
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//chrome/version.gni") # TODO layering violation!
+import("//build/util/process_version.gni")
import("//chromecast/chromecast.gni")
import("//testing/test.gni")
@@ -200,6 +200,9 @@ process_version("cast_version") {
template_file = "version.h.in"
output = "$target_gen_dir/version.h"
+ sources = [
+ "//chrome/VERSION",
+ ]
extra_args = [
"-e",
"VERSION_FULL=\"%s.%s.%s.%s\"%(MAJOR,MINOR,BUILD,PATCH)",
« no previous file with comments | « chrome_elf/BUILD.gn ('k') | chromecast/crypto/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698