Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chromecast/base/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)
Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome_elf/BUILD.gn ('k') | chromecast/crypto/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//chrome/version.gni") # TODO layering violation! 5 import("//build/util/process_version.gni")
6 import("//chromecast/chromecast.gni") 6 import("//chromecast/chromecast.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 8
9 if (is_android) { 9 if (is_android) {
10 import("//build/config/android/rules.gni") 10 import("//build/config/android/rules.gni")
11 } 11 }
12 12
13 declare_args() { 13 declare_args() {
14 # Denotes the type of Cast product. This is #defined as CAST_PRODUCT_TYPE in 14 # Denotes the type of Cast product. This is #defined as CAST_PRODUCT_TYPE in
15 # version.h. This is an integer in the range [0-4]. 15 # version.h. This is an integer in the range [0-4].
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 "//base", 193 "//base",
194 "//chromecast/public", 194 "//chromecast/public",
195 ] 195 ]
196 } 196 }
197 } 197 }
198 198
199 process_version("cast_version") { 199 process_version("cast_version") {
200 template_file = "version.h.in" 200 template_file = "version.h.in"
201 output = "$target_gen_dir/version.h" 201 output = "$target_gen_dir/version.h"
202 202
203 sources = [
204 "//chrome/VERSION",
205 ]
203 extra_args = [ 206 extra_args = [
204 "-e", 207 "-e",
205 "VERSION_FULL=\"%s.%s.%s.%s\"%(MAJOR,MINOR,BUILD,PATCH)", 208 "VERSION_FULL=\"%s.%s.%s.%s\"%(MAJOR,MINOR,BUILD,PATCH)",
206 "-e", 209 "-e",
207 "CAST_BUILD_RELEASE=\"$cast_build_release\"", 210 "CAST_BUILD_RELEASE=\"$cast_build_release\"",
208 "-e", 211 "-e",
209 "CAST_BUILD_INCREMENTAL=\"$cast_build_incremental\"", 212 "CAST_BUILD_INCREMENTAL=\"$cast_build_incremental\"",
210 "-e", 213 "-e",
211 "CAST_PRODUCT_TYPE=$cast_product_type", 214 "CAST_PRODUCT_TYPE=$cast_product_type",
212 ] 215 ]
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 "$java_src_dir/org/chromium/chromecast/base/ChromecastConfigAndroid.java", 247 "$java_src_dir/org/chromium/chromecast/base/ChromecastConfigAndroid.java",
245 "$java_src_dir/org/chromium/chromecast/base/DumpstateWriter.java", 248 "$java_src_dir/org/chromium/chromecast/base/DumpstateWriter.java",
246 "$java_src_dir/org/chromium/chromecast/base/SystemTimeChangeNotifierAndroi d.java", 249 "$java_src_dir/org/chromium/chromecast/base/SystemTimeChangeNotifierAndroi d.java",
247 ] 250 ]
248 251
249 deps = [ 252 deps = [
250 "//base:base_java", 253 "//base:base_java",
251 ] 254 ]
252 } 255 }
253 } 256 }
OLDNEW
« no previous file with comments | « chrome_elf/BUILD.gn ('k') | chromecast/crypto/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698