chrome_elf/BUILD.gn - Issue 2308313003: gn: Generalize process_version() and move it to build/util

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/BUILD.gn

Issue 2308313003: gn: Generalize process_version() and move it to build/util (Closed)

Patch Set: Move branding_file_path to chrome/process_version_rc_template.gni Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_elf/BUILD.gn

diff --git a/chrome_elf/BUILD.gn b/chrome_elf/BUILD.gn

index 3de5fb3e83b1697adbb900f5bf83f7cecbad59a4..1207191e0553d320c1886dc91edb00a3c1d5eab5 100644

--- a/chrome_elf/BUILD.gn

+++ b/chrome_elf/BUILD.gn

@@ -6,15 +6,14 @@

# Please don't add dependencies on any other system libraries.

import("//build/config/win/manifest.gni")

-import("//chrome/version.gni")

+import("//chrome/process_version_rc_template.gni")

import("//testing/test.gni")

##------------------------------------------------------------------------------

## chrome_elf

##------------------------------------------------------------------------------

-process_version("chrome_elf_resources") {

- template_file = chrome_version_rc_template

+process_version_rc_template("chrome_elf_resources") {

sources = [

"chrome_elf.ver",

]

« no previous file with comments | « chrome/version.gni ('k') | chromecast/base/BUILD.gn » ('j') | no next file with comments »