Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2308143002: Fix DelegatedOutputSurface in Blimp (Closed)

Created:
4 years, 3 months ago by David Trainor- moved to gerrit
Modified:
4 years, 3 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DelegatedOutputSurface in Blimp Make sure to build a BeginFrameSource when binding to the OutputSurfaceClient. Without this the compositor doesn't push frames. This was broken by https://codereview.chromium.org/2083423006 because BlimpLayerTreeSettings sets use_output_surface_begin_frame_source but one wasn't provided by the DelegatedOutputSurface. Infrastructure to add a Blimp test for this is almost complete and will be added in a follow up CL! BUG= Committed: https://crrev.com/e5cc6b1bd2e6ab945027f79a9439966bec3ece38 Cr-Commit-Position: refs/heads/master@{#416395}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M blimp/client/core/compositor/delegated_output_surface.h View 3 chunks +8 lines, -0 lines 0 comments Download
M blimp/client/core/compositor/delegated_output_surface.cc View 2 chunks +9 lines, -0 lines 1 comment Download
M blimp/client/support/compositor/blimp_layer_tree_settings.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
David Trainor- moved to gerrit
ptal thanks!
4 years, 3 months ago (2016-09-02 22:54:08 UTC) #2
Khushal
4 years, 3 months ago (2016-09-02 22:55:21 UTC) #3
Khushal
lgtm
4 years, 3 months ago (2016-09-02 22:55:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2308143002/1
4 years, 3 months ago (2016-09-02 23:10:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 23:48:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5cc6b1bd2e6ab945027f79a9439966bec3ece38 Cr-Commit-Position: refs/heads/master@{#416395}
4 years, 3 months ago (2016-09-02 23:51:03 UTC) #9
Khushal
4 years, 3 months ago (2016-09-03 16:04:32 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2308143002/diff/1/blimp/client/core/composito...
File blimp/client/core/compositor/delegated_output_surface.cc (right):

https://codereview.chromium.org/2308143002/diff/1/blimp/client/core/composito...
blimp/client/core/compositor/delegated_output_surface.cc:56:
client->SetBeginFrameSource(begin_frame_source_.get());
Woops. Also destroy the |begin_frame_source_| and clean up the reference in
DetachFromClient?

Powered by Google App Engine
This is Rietveld 408576698