Fix DelegatedOutputSurface in Blimp

blimp/client/core/compositor/delegated_output_surface.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/client/core/compositor/delegated_output_surface.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_checker.h"
+#include "base/threading/thread_task_runner_handle.h"
 #include "cc/output/compositor_frame.h"
+#include "cc/output/output_surface_client.h"
+#include "cc/scheduler/begin_frame_source.h"
+#include "cc/scheduler/delay_based_time_source.h"
 
 namespace blimp {
 namespace client {
 
 DelegatedOutputSurface::DelegatedOutputSurface(
     scoped_refptr<cc::ContextProvider> compositor_context_provider,
     scoped_refptr<cc::ContextProvider> worker_context_provider,
     scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
     base::WeakPtr<BlimpOutputSurfaceClient> client)
     : cc::OutputSurface(std::move(compositor_context_provider),
@@ skipping 16 matching lines @@
 }
 
 uint32_t DelegatedOutputSurface::GetFramebufferCopyTextureFormat() {
   NOTREACHED() << "Should not be called on delegated output surface";
   return 0;
 }
 
 bool DelegatedOutputSurface::BindToClient(cc::OutputSurfaceClient* client) {
   bool success = cc::OutputSurface::BindToClient(client);
   if (success) {
+    begin_frame_source_ = base::MakeUnique<cc::DelayBasedBeginFrameSource>(
+        base::MakeUnique<cc::DelayBasedTimeSource>(
+            base::ThreadTaskRunnerHandle::Get().get()));
+    client->SetBeginFrameSource(begin_frame_source_.get());

[Khushal, 2016/09/03 16:04:31]

Woops. Also destroy the |begin_frame_source_| and clean up the reference in
DetachFromClient?

+
     main_task_runner_->PostTask(
         FROM_HERE, base::Bind(&BlimpOutputSurfaceClient::BindToOutputSurface,
                               client_, weak_factory_.GetWeakPtr()));
   }
   return success;
 }
 
 void DelegatedOutputSurface::SwapBuffers(cc::CompositorFrame frame) {
   DCHECK(client_thread_checker_.CalledOnValidThread());
 
@@ skipping 11 matching lines @@
     main_task_runner_->PostTask(
         FROM_HERE,
         base::Bind(&BlimpOutputSurfaceClient::UnbindOutputSurface, client_));
   }
 
   weak_factory_.InvalidateWeakPtrs();
 }
 
 }  // namespace client
 }  // namespace blimp