Remove default begin frame sources from the renderer

Remove default begin frame sources from the renderer

This changes both cc proxies to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889
Committed: https://crrev.com/5593b84f823ee1517347cf773c6cd1854c0268ba
Cr-Original-Commit-Position: refs/heads/master@{#415757}
Cr-Commit-Position: refs/heads/master@{#416033}

[enne (OOO), 2016-06-24 18:11:17]

enne@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2016-06-24 22:35:29]

lgtm

[enne (OOO), 2016-07-27 18:35:40]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 18:36:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 19:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 19:37:54]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-08-12 21:40:30]

Unified begin frame stuff maybe just might possibly stick, so will land this
now.  <_<

[enne (OOO), 2016-08-12 21:40:32]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-08-12 21:40:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2083423006/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-12 21:41:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 23:03:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-12 23:05:07]

Description was changed from

==========
Always use an external begin frame source in the renderer

Tests still aren't using an external begin frame source, so this is just
a staging step.  The next step is to move BFS into output surface,
remove external begin frame sources from cc's API, and then to remove
the default BFS in cc's proxies once output sources are the only way to
get a BFS.
==========

to

==========
Always use an external begin frame source in the renderer

Tests still aren't using an external begin frame source, so this is just
a staging step.  The next step is to move BFS into output surface,
remove external begin frame sources from cc's API, and then to remove
the default BFS in cc's proxies once output sources are the only way to
get a BFS.

Committed: https://crrev.com/3ba9b9d3500d799ee36bd41d0b36aecbc924111a
Cr-Commit-Position: refs/heads/master@{#411809}
==========

[commit-bot: I haz the power, 2016-08-12 23:05:08]

Patchset 4 (id:??) landed as
https://crrev.com/3ba9b9d3500d799ee36bd41d0b36aecbc924111a
Cr-Commit-Position: refs/heads/master@{#411809}

[caseq, 2016-08-13 00:58:24]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2241083002/ by caseq@chromium.org.

The reason for reverting is: This apparently broke blimp tests:
https://build.chromium.org/p/chromium.linux/builders/Blimp%20Linux%20%28dbg%2....

[danakj, 2016-08-13 00:59:44]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-08-13 00:59:45]

Probably my fault, I made them set use_output_surface_bfs?

[enne (OOO), 2016-08-15 22:33:42]

Description was changed from

==========
Always use an external begin frame source in the renderer

Tests still aren't using an external begin frame source, so this is just
a staging step.  The next step is to move BFS into output surface,
remove external begin frame sources from cc's API, and then to remove
the default BFS in cc's proxies once output sources are the only way to
get a BFS.

Committed: https://crrev.com/3ba9b9d3500d799ee36bd41d0b36aecbc924111a
Cr-Commit-Position: refs/heads/master@{#411809}
==========

to

==========
Always use an external begin frame source in the renderer

Tests still aren't using an external begin frame source, so this is just
a staging step.  The next step is to move BFS into output surface,
remove external begin frame sources from cc's API, and then to remove
the default BFS in cc's proxies once output sources are the only way to
get a BFS.

Committed: https://crrev.com/3ba9b9d3500d799ee36bd41d0b36aecbc924111a
Cr-Commit-Position: refs/heads/master@{#411809}
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-08-15 23:57:01]

Description was changed from

==========
Always use an external begin frame source in the renderer

Tests still aren't using an external begin frame source, so this is just
a staging step.  The next step is to move BFS into output surface,
remove external begin frame sources from cc's API, and then to remove
the default BFS in cc's proxies once output sources are the only way to
get a BFS.

Committed: https://crrev.com/3ba9b9d3500d799ee36bd41d0b36aecbc924111a
Cr-Commit-Position: refs/heads/master@{#411809}
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove default begin frame sources from the renderer
This changes the threaded proxy to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).  In a future patch,
use_external_begin_frame_source will be removed and
use_output_surface_begin_frame_source will be used instead.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-08-16 00:18:45]

Description was changed from

==========
Remove default begin frame sources from the renderer
This changes the threaded proxy to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).  In a future patch,
use_external_begin_frame_source will be removed and
use_output_surface_begin_frame_source will be used instead.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove default begin frame sources from the renderer

This changes the threaded proxy to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).  In a future patch,
use_external_begin_frame_source will be removed and
use_output_surface_begin_frame_source will be used instead.

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-08-16 00:19:04]

Description was changed from

==========
Remove default begin frame sources from the renderer

This changes the threaded proxy to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).  In a future patch,
use_external_begin_frame_source will be removed and
use_output_surface_begin_frame_source will be used instead.

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove default begin frame sources from the renderer

This changes the threaded proxy to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-08-16 00:21:01]

Description was changed from

==========
Remove default begin frame sources from the renderer

This changes the threaded proxy to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove default begin frame sources from the renderer

This changes both cc proxies to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-08-16 00:26:06]

danakj: thanks for the change LayerTreeSettings default suggestion.  Do you want
to peek at this before I reland it?

[danakj, 2016-08-16 00:30:04]

LGTM

https://codereview.chromium.org/2083423006/diff/100001/cc/trees/single_thread...
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/2083423006/diff/100001/cc/trees/single_thread...
cc/trees/single_thread_proxy.cc:80: // TODO(enne): make all BFS come from the
output surface.
nit: Make

https://codereview.chromium.org/2083423006/diff/100001/cc/trees/single_thread...
cc/trees/single_thread_proxy.cc:84: external_begin_frame_source_.get());
nit: no .get()

https://codereview.chromium.org/2083423006/diff/100001/cc/trees/single_thread...
cc/trees/single_thread_proxy.cc:87: !external_begin_frame_source_.get());
nit: no .get()

[enne (OOO), 2016-08-16 17:27:55]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-08-16 17:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2083423006/#ps120001
(title: "danakj comments")

[commit-bot: I haz the power, 2016-08-16 17:28:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 17:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 17:45:44]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[danakj, 2016-08-16 17:47:25]

https://codereview.chromium.org/2083423006/diff/120001/content/renderer/gpu/r...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/2083423006/diff/120001/content/renderer/gpu/r...
content/renderer/gpu/render_widget_compositor.cc:457: if
(command_line->HasSwitch(switches::kUseRemoteCompositing)) {
cmd.HasSwitch

[enne (OOO), 2016-08-16 20:13:26]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-08-16 20:13:27]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2083423006/#ps140001
(title: "Fix last minute edit compilation problem")

[commit-bot: I haz the power, 2016-08-16 20:13:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 20:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 20:21:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2016-08-16 22:17:54]

Oh, this would break the vsync settings if you used
--disable-begin-frame-scheduling.  I'll wait until next week to land this.

[enne (OOO), 2016-08-31 18:46:50]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:47:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-08-31 18:58:31]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:59:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2016-08-31 20:24:27]

Ok, now it's time to land this.  :)

[commit-bot: I haz the power, 2016-08-31 21:13:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:13:51]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-08-31 21:16:37]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-08-31 21:16:38]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2083423006/#ps200001
(title: "Remove redundant settings")

[commit-bot: I haz the power, 2016-08-31 21:17:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:23:05]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-08-31 21:24:59]

Description was changed from

==========
Remove default begin frame sources from the renderer

This changes both cc proxies to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Remove default begin frame sources from the renderer

This changes both cc proxies to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889
Cr-Commit-Position: refs/heads/master@{#415757}
==========

[commit-bot: I haz the power, 2016-08-31 21:25:00]

Patchset 11 (id:??) landed as
https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889
Cr-Commit-Position: refs/heads/master@{#415757}

[fgorski, 2016-08-31 22:15:56]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2296353002/ by fgorski@chromium.org.

The reason for reverting is: Speculative revert as there are some bots failing
with a common and related stack..

[enne (OOO), 2016-09-01 18:44:42]

Am going to reland this as https://codereview.chromium.org/2286273003 appears to
be the problematic CL.

[enne (OOO), 2016-09-01 18:45:03]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2016-09-01 18:45:03]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2083423006/#ps220001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-01 18:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:21:45]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-09-01 20:24:20]

Description was changed from

==========
Remove default begin frame sources from the renderer

This changes both cc proxies to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889
Cr-Commit-Position: refs/heads/master@{#415757}
==========

to

==========
Remove default begin frame sources from the renderer

This changes both cc proxies to no longer create default begin frame
sources.  In cc, it must either be the case that an external begin frame
source is provided (with use_external_begin_frame_source set) or the
output surface provides a begin frame source (with
use_output_surface_begin_frame_source).

This changes the world from three states of BFS creation (default,
output surface provided, and external) to only two (output surface
provided and external).  In the future, external will also be removed.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/da025c649b0c2339771f2b06c482dcf8e388e889
Committed: https://crrev.com/5593b84f823ee1517347cf773c6cd1854c0268ba
Cr-Original-Commit-Position: refs/heads/master@{#415757}
Cr-Commit-Position: refs/heads/master@{#416033}
==========

[commit-bot: I haz the power, 2016-09-01 20:24:22]

Patchset 12 (id:??) landed as
https://crrev.com/5593b84f823ee1517347cf773c6cd1854c0268ba
Cr-Commit-Position: refs/heads/master@{#416033}