Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2307953003: Remove CFX_Matrix::Copy() in favor of assignment (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_Matrix::Copy() in favor of assignment The default assignment operator will suffice and allows us to write matrix1 = matrix2; Committed: https://pdfium.googlesource.com/pdfium/+/6296f2d501e2749d98e890ed722f923ee584c9ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -27 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_allstates.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M core/fxcrt/include/fx_coordinates.h View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Lei, more stuff that's driving me crazy. Thanks.
4 years, 3 months ago (2016-09-02 23:35:03 UTC) #5
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-02 23:48:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2307953003/1
4 years, 3 months ago (2016-09-02 23:56:04 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:56:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6296f2d501e2749d98e890ed722f923ee584...

Powered by Google App Engine
This is Rietveld 408576698