core/fpdfapi/fpdf_page/fpdf_page_parser.cpp - Issue 2307953003: Remove CFX_Matrix::Copy() in favor of assignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

Issue 2307953003: Remove CFX_Matrix::Copy() in favor of assignment (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

index 83e66eae61794d58363da9b21b5c4542ff2542b1..d7f1f3c3e01774e79e87bb5a893d52b31360d816 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser.cpp

@@ -777,8 +777,7 @@ CPDF_ImageObject* CPDF_StreamContentParser::AddImage(CPDF_Stream* pStream,

if (!pStream && !pImage)

return nullptr;

- CFX_Matrix ImageMatrix;

- ImageMatrix.Copy(m_pCurStates->m_CTM);

+ CFX_Matrix ImageMatrix = m_pCurStates->m_CTM;

ImageMatrix.Concat(m_mtContentToUser);

std::unique_ptr<CPDF_ImageObject> pImageObj(new CPDF_ImageObject);