Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 230793003: Fix creating platform font on Windows (Closed)

Created:
6 years, 8 months ago by Tomasz Moniuszko
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix creating platform font on Windows fdwCharSet param changed from 0 to DEFAULT_CHARSET (which is defined to 1). ScriptShape fails to generate glyphs on Windows XP for some complex scripts (Hindi text for instance) if font is created with fdwCharSet=0. Other paramaters are unchanged because they still expand to 0. BUG=361994 TEST=On Windows XP, go to Control Panel and Regional and Language Options. Under Languages tab check Install files for Complex Script and right-to-left languages (including Thai) and Install files for East Asian languages. Click Details and install Hindi language. Launch Chromium. Go to advanced settings and go to Languages. Add Hindi language and click Display Chromium in this language button. Restart Chromium. Expected result: Hindi font glyphs should be properly generated for all UI elements (tabs, menus, notification panels). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263001 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/gfx/platform_font_win.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Tomasz Moniuszko
6 years, 8 months ago (2014-04-09 14:09:58 UTC) #1
Alexei Svitkine (slow)
It seems like there should be a bug associated with this CL given that you ...
6 years, 8 months ago (2014-04-09 15:36:38 UTC) #2
Tomasz Moniuszko
I've created a bug report and added TEST= instructions.
6 years, 8 months ago (2014-04-10 09:58:05 UTC) #3
Alexei Svitkine (slow)
LGTM Please also include the expected results in the TEST= line (and I think mention ...
6 years, 8 months ago (2014-04-10 13:54:41 UTC) #4
Tomasz Moniuszko
OK. Thanks for review!
6 years, 8 months ago (2014-04-10 14:01:22 UTC) #5
Tomasz Moniuszko
The CQ bit was checked by tmoniuszko@opera.com
6 years, 8 months ago (2014-04-10 14:01:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/230793003/1
6 years, 8 months ago (2014-04-10 14:02:12 UTC) #7
commit-bot: I haz the power
Change committed as 263001
6 years, 8 months ago (2014-04-10 16:02:57 UTC) #8
jwd
A revert of this CL has been created in https://codereview.chromium.org/228703007/ by jwd@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-10 18:59:59 UTC) #9
Alexei Svitkine (slow)
Test output: (view as text)<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081/steps/ui_unittests/logs/ElidedText/text> RenderTextTest.ElidedText (run #1): [ RUN ] RenderTextTest.ElidedText c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475): error: Value ...
6 years, 8 months ago (2014-04-10 19:04:40 UTC) #10
Tomasz Moniuszko
On 2014/04/10 19:04:40, Alexei Svitkine wrote: > Test output: > > (view as > text)<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081/steps/ui_unittests/logs/ElidedText/text> ...
6 years, 5 months ago (2014-06-25 11:38:31 UTC) #11
Tomasz Moniuszko
The CQ bit was checked by tmoniuszko@opera.com
6 years, 5 months ago (2014-06-25 11:39:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/230793003/1
6 years, 5 months ago (2014-06-25 11:41:04 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-06-25 15:25:36 UTC) #14
Message was sent while issue was closed.
Change committed as 279719

Powered by Google App Engine
This is Rietveld 408576698