Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 228703007: Revert of Fix creating platform font on Windows (Closed)

Created:
6 years, 8 months ago by jwd
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Fix creating platform font on Windows (https://codereview.chromium.org/230793003/) Reason for revert: Suspect this broke RenderTextTest.ElidedText in http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081. Original issue's description: > Fix creating platform font on Windows > > fdwCharSet param changed from 0 to DEFAULT_CHARSET (which is defined to > 1). ScriptShape fails to generate glyphs on Windows XP for some complex > scripts (Hindi text for instance) if font is created with fdwCharSet=0. > > Other paramaters are unchanged because they still expand to 0. > > BUG=361994 > > TEST=On Windows XP, go to Control Panel and Regional and > Language Options. Under Languages tab check Install files > for Complex Script and right-to-left languages (including > Thai) and Install files for East Asian languages. Click > Details and install Hindi language. Launch Chromium. Go to > advanced settings and go to Languages. Add Hindi language > and click Display Chromium in this language button. Restart > Chromium. Expected result: Hindi font glyphs should be > properly generated for all UI elements (tabs, menus, > notification panels). > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263001 TBR=asvitkine@chromium.org,msw@chromium.org,tmoniuszko@opera.com NOTREECHECKS=true NOTRY=true BUG=361994 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M ui/gfx/platform_font_win.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jwd
Created Revert of Fix creating platform font on Windows
6 years, 8 months ago (2014-04-10 19:00:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/228703007/1
6 years, 8 months ago (2014-04-10 19:00:24 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 19:01:30 UTC) #3
Message was sent while issue was closed.
Change committed as 263040

Powered by Google App Engine
This is Rietveld 408576698