Fix creating platform font on Windows

Fix creating platform font on Windows

fdwCharSet param changed from 0 to DEFAULT_CHARSET (which is defined to
1). ScriptShape fails to generate glyphs on Windows XP for some complex
scripts (Hindi text for instance) if font is created with fdwCharSet=0.

Other paramaters are unchanged because they still expand to 0.

BUG=361994
TEST=On Windows XP, go to Control Panel and Regional and
Language Options. Under Languages tab check Install files
for Complex Script and right-to-left languages (including
Thai) and Install files for East Asian languages. Click
Details and install Hindi language. Launch Chromium. Go to
advanced settings and go to Languages. Add Hindi language
and click Display Chromium in this language button. Restart
Chromium. Expected result: Hindi font glyphs should be
properly generated for all UI elements (tabs, menus,
notification panels).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263001

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279719

[Alexei Svitkine (slow), 2014-04-09 15:36:38]

It seems like there should be a bug associated with this CL given that you
mention that the current behaviour actually gives the wrong result in some
cases. Can you file one or associated the CL with an existing one?

Also, is it possible to add a TEST= line that mentions how someone could verify
that the fix is working as expected?

[Tomasz Moniuszko, 2014-04-10 09:58:05]

I've created a bug report and added TEST= instructions.

[Alexei Svitkine (slow), 2014-04-10 13:54:41]

LGTM

Please also include the expected results in the TEST= line (and I think mention
that this is on Windows XP).

It would be good to have a unit test for this, but it's not clear to me whether
it's possible to have one given that this relies on XP machine with some
language packs installed and that may not match our bot configs. So I guess I'm
okay without having one.

[Tomasz Moniuszko, 2014-04-10 14:01:22]

OK. Thanks for review!

[Tomasz Moniuszko, 2014-04-10 14:01:28]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2014-04-10 14:02:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/230793003/1

[commit-bot: I haz the power, 2014-04-10 16:02:57]

Change committed as 263001

[jwd, 2014-04-10 18:59:59]

A revert of this CL has been created in
https://codereview.chromium.org/228703007/ by jwd@chromium.org.

The reason for reverting is: Suspect this broke RenderTextTest.ElidedText in
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds....
.

[Alexei Svitkine (slow), 2014-04-10 19:04:40]

Test output:

(view as
text)<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081/steps/ui_unittests/logs/ElidedText/text>

RenderTextTest.ElidedText (run #1):
[ RUN      ] RenderTextTest.ElidedText
c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
error: Value of: render_text->GetLayoutText()
  Actual: L"0123\x915\x93F\x2026"
Expected: WideToUTF16(cases[i].layout_text)
Which is: L"0123\x915\x2026"
->For case 16: 0123??

[  FAILED  ] RenderTextTest.ElidedText (219 ms)

RenderTextTest.ElidedText (run #2):
[ RUN      ] RenderTextTest.ElidedText
c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
error: Value of: render_text->GetLayoutText()
  Actual: L"0123\x915\x93F\x2026"
Expected: WideToUTF16(cases[i].layout_text)
Which is: L"0123\x915\x2026"
->For case 16: 0123??

[  FAILED  ] RenderTextTest.ElidedText (47 ms)

RenderTextTest.ElidedText (run #3):
[ RUN      ] RenderTextTest.ElidedText
c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
error: Value of: render_text->GetLayoutText()
  Actual: L"0123\x915\x93F\x2026"
Expected: WideToUTF16(cases[i].layout_text)
Which is: L"0123\x915\x2026"
->For case 16: 0123??

[  FAILED  ] RenderTextTest.ElidedText (31 ms)

RenderTextTest.ElidedText (run #4):
[ RUN      ] RenderTextTest.ElidedText
c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
error: Value of: render_text->GetLayoutText()
  Actual: L"0123\x915\x93F\x2026"
Expected: WideToUTF16(cases[i].layout_text)
Which is: L"0123\x915\x2026"
->For case 16: 0123??

[  FAILED  ] RenderTextTest.ElidedText (31 ms)



On Thu, Apr 10, 2014 at 3:00 PM, <jwd@chromium.org> wrote:

> A revert of this CL has been created in
> https://codereview.chromium.org/228703007/ by jwd@chromium.org.
>
> The reason for reverting is: Suspect this broke RenderTextTest.ElidedText
> in
> http://build.chromium.org/p/chromium.win/builders/XP%
> 20Tests%20%283%29/builds/27081.
> .
>
> https://codereview.chromium.org/230793003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Tomasz Moniuszko, 2014-06-25 11:38:31]

On 2014/04/10 19:04:40, Alexei Svitkine wrote:
> Test output:
> 
> (view as
>
text)<http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081/steps/ui_unittests/logs/ElidedText/text>
> 
> RenderTextTest.ElidedText (run #1):
> [ RUN      ] RenderTextTest.ElidedText
> c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
> error: Value of: render_text->GetLayoutText()
>   Actual: L"0123\x915\x93F\x2026"
> Expected: WideToUTF16(cases[i].layout_text)
> Which is: L"0123\x915\x2026"
> ->For case 16: 0123??
> 
> [  FAILED  ] RenderTextTest.ElidedText (219 ms)
> 
> RenderTextTest.ElidedText (run #2):
> [ RUN      ] RenderTextTest.ElidedText
> c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
> error: Value of: render_text->GetLayoutText()
>   Actual: L"0123\x915\x93F\x2026"
> Expected: WideToUTF16(cases[i].layout_text)
> Which is: L"0123\x915\x2026"
> ->For case 16: 0123??
> 
> [  FAILED  ] RenderTextTest.ElidedText (47 ms)
> 
> RenderTextTest.ElidedText (run #3):
> [ RUN      ] RenderTextTest.ElidedText
> c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
> error: Value of: render_text->GetLayoutText()
>   Actual: L"0123\x915\x93F\x2026"
> Expected: WideToUTF16(cases[i].layout_text)
> Which is: L"0123\x915\x2026"
> ->For case 16: 0123??
> 
> [  FAILED  ] RenderTextTest.ElidedText (31 ms)
> 
> RenderTextTest.ElidedText (run #4):
> [ RUN      ] RenderTextTest.ElidedText
> c:\b\build\slave\cr-win-rel\build\src\ui\gfx\render_text_unittest.cc(475):
> error: Value of: render_text->GetLayoutText()
>   Actual: L"0123\x915\x93F\x2026"
> Expected: WideToUTF16(cases[i].layout_text)
> Which is: L"0123\x915\x2026"
> ->For case 16: 0123??
> 
> [  FAILED  ] RenderTextTest.ElidedText (31 ms)
> 
> 
> 
> On Thu, Apr 10, 2014 at 3:00 PM, <mailto:jwd@chromium.org> wrote:
> 
> > A revert of this CL has been created in
> > https://codereview.chromium.org/228703007/ by mailto:jwd@chromium.org.
> >
> > The reason for reverting is: Suspect this broke RenderTextTest.ElidedText
> > in
> > http://build.chromium.org/p/chromium.win/builders/XP%25
> > 20Tests%20%283%29/builds/27081.
> > .
> >
> > https://codereview.chromium.org/230793003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

With this patch integrated https://codereview.chromium.org/251773002/ test is OK
now.

[Tomasz Moniuszko, 2014-06-25 11:39:29]

The CQ bit was checked by tmoniuszko@opera.com

[commit-bot: I haz the power, 2014-06-25 11:41:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/230793003/1

[commit-bot: I haz the power, 2014-06-25 15:25:36]

Change committed as 279719