DevTools: Allow clicks to register in SSP when swatch popover is open

DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779
Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
Cr-Commit-Position: refs/heads/master@{#417109}

[flandy, 2016-09-02 01:41:55]

flandy@google.com changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[flandy, 2016-09-02 01:41:56]

Please take a look.

[lushnikov, 2016-09-06 15:09:40]

https://codereview.chromium.org/2307463004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
(right):

https://codereview.chromium.org/2307463004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js:92:
if (!commitEdit)
this is something we might regress later; lets add a test

[lushnikov, 2016-09-07 16:48:07]

For the record: since the issue is not constantly reproducible and depends on
both focusout and mouseclick events, it turned out to be hard to write a test.

https://codereview.chromium.org/2307463004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
(right):

https://codereview.chromium.org/2307463004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js:92:
if (!commitEdit)
let's make a bug, describing bad behavior, and put a comment

[flandy, 2016-09-07 17:30:14]

Description was changed from

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=639095
==========

to

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=639095
BUG=644779
==========

[flandy, 2016-09-07 17:35:14]

Ptal.

https://codereview.chromium.org/2307463004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
(right):

https://codereview.chromium.org/2307463004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js:92:
if (!commitEdit)
On 2016/09/07 16:48:07, lushnikov wrote:
> let's make a bug, describing bad behavior, and put a comment

Done.

[flandy, 2016-09-07 19:05:17]

Description was changed from

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=639095
BUG=644779
==========

to

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=639095, 644779
==========

[flandy, 2016-09-07 19:05:35]

Description was changed from

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=639095, 644779
==========

to

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779
==========

[lushnikov, 2016-09-07 21:22:57]

lgtm, thanks

[flandy, 2016-09-07 21:31:12]

The CQ bit was checked by flandy@google.com

[commit-bot: I haz the power, 2016-09-07 21:32:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:04:54]

Description was changed from

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779
==========

to

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779
==========

[commit-bot: I haz the power, 2016-09-07 23:04:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 23:08:00]

Description was changed from

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779
==========

to

==========
DevTools: Allow clicks to register in SSP when swatch popover is open

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779

Committed: https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
Cr-Commit-Position: refs/heads/master@{#417109}
==========

[commit-bot: I haz the power, 2016-09-07 23:08:01]

Patchset 2 (id:??) landed as
https://crrev.com/f8152e0a1d9157f873363a8b40951af0f6e0d6eb
Cr-Commit-Position: refs/heads/master@{#417109}

[flandy, 2016-09-08 01:01:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2320533005/ by flandy@google.com.

The reason for reverting is: This breaks editing color swatches within shadow
swatches. If you edit the color, and then edit the shadow, it reverts to the
original color.

We should further examine the effects of majorChange=true in applyStyleText. .