Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

Issue 2307463004: DevTools: Allow clicks to register in SSP when swatch popover is open (Closed)
Patch Set: Add comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js b/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
index b3ce35a17d4446673015a85b0613909a129eb3df..df1713f2d675d3ebba4867e304a1650873813054 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
@@ -79,8 +79,9 @@ WebInspector.BezierPopoverIcon.prototype = {
this._bezierEditor.removeEventListener(WebInspector.BezierEditor.Events.BezierChanged, this._boundBezierChanged);
delete this._bezierEditor;
- var propertyText = commitEdit ? this._treeElement.renderedPropertyText() : this._originalPropertyText;
- this._treeElement.applyStyleText(propertyText, true);
+ // Clicking between swatches in the same section should open each swatch popover. crbug.com/644779
+ if (!commitEdit)
+ this._treeElement.applyStyleText(this._originalPropertyText, true);
this._treeElement.parentPane().setEditingStyle(false);
delete this._originalPropertyText;
}
@@ -206,8 +207,9 @@ WebInspector.ColorSwatchPopoverIcon.prototype = {
this._spectrum.removeEventListener(WebInspector.Spectrum.Events.ColorChanged, this._boundSpectrumChanged);
delete this._spectrum;
- var propertyText = commitEdit ? this._treeElement.renderedPropertyText() : this._originalPropertyText;
- this._treeElement.applyStyleText(propertyText, true);
+ // Clicking between swatches in the same section should open each swatch popover. crbug.com/644779
+ if (!commitEdit)
+ this._treeElement.applyStyleText(this._originalPropertyText, true);
this._treeElement.parentPane().setEditingStyle(false);
delete this._originalPropertyText;
}
@@ -288,8 +290,9 @@ WebInspector.ShadowSwatchPopoverHelper.prototype = {
this._cssShadowEditor.removeEventListener(WebInspector.CSSShadowEditor.Events.ShadowChanged, this._boundShadowChanged);
delete this._cssShadowEditor;
- var propertyText = commitEdit ? this._treeElement.renderedPropertyText() : this._originalPropertyText;
- this._treeElement.applyStyleText(propertyText, true);
+ // Clicking between swatches in the same section should open each swatch popover. crbug.com/644779
+ if (!commitEdit)
+ this._treeElement.applyStyleText(this._originalPropertyText, true);
this._treeElement.parentPane().setEditingStyle(false);
delete this._originalPropertyText;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698