third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2307463004: DevTools: Allow clicks to register in SSP when swatch popover is open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2307463004: DevTools: Allow clicks to register in SSP when swatch popover is open (Closed)

Patch Set: Add comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/ColorSwatch.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index 036fc632880781cf855a60d299d6f6d7775d33e4..276c33ce6446d6754ffcddd4f119c941bc808f36 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -2048,8 +2048,9 @@ WebInspector.StylePropertyTreeElement.prototype = {

var cssShadowSwatch = WebInspector.CSSShadowSwatch.create();

cssShadowSwatch.setCSSShadow(shadows[i]);

new WebInspector.ShadowSwatchPopoverHelper(this, swatchPopoverHelper, cssShadowSwatch);

- if (cssShadowSwatch.colorSwatch())

- var colorSwatchIcon = new WebInspector.ColorSwatchPopoverIcon(this, swatchPopoverHelper, cssShadowSwatch.colorSwatch());

+ var colorSwatch = cssShadowSwatch.colorSwatch();

+ if (colorSwatch)

+ new WebInspector.ColorSwatchPopoverIcon(this, swatchPopoverHelper, colorSwatch);

container.appendChild(cssShadowSwatch);

}

return container;