Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 23072005: Revert 217286 "Revert 217273 "Android: run dex with the --force-..." (Closed)

Created:
7 years, 4 months ago by dmazzoni
Modified:
7 years, 4 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 217286 "Revert 217273 "Android: run dex with the --force-..." This is reverting the revert - it turns out to not be the cause of the test failure. > Revert 217273 "Android: run dex with the --force-jumbo switch." > > I think it caused Android tests such as this one to fail: > MinidumpWriterTest.MinidumpSizeLimit > > Either way, it was submitted without try jobs. Always run try jobs. > > > Android: run dex with the --force-jumbo switch. > > > > This is needed to merge dex files collectively containing more than 65536 > > strings. More details at > > https://code.google.com/p/android/issues/detail?id=40772 and in the bug. > > > > BUG=272064 > > R=andrewhayden@chromium.org > > > > Review URL: https://codereview.chromium.org/22950006 > > TBR=ppi@chromium.org > > Review URL: https://codereview.chromium.org/23096002 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M trunk/src/build/android/gyp/dex.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
7 years, 4 months ago (2013-08-13 18:40:21 UTC) #1
dmazzoni
7 years, 4 months ago (2013-08-13 18:40:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r217297.

Powered by Google App Engine
This is Rietveld 408576698