Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Issue 23096002: Revert 217273 "Android: run dex with the --force-jumbo switch." (Closed)

Created:
7 years, 4 months ago by dmazzoni
Modified:
7 years, 4 months ago
Reviewers:
ppi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 217273 "Android: run dex with the --force-jumbo switch." I think it caused Android tests such as this one to fail: MinidumpWriterTest.MinidumpSizeLimit Either way, it was submitted without try jobs. Always run try jobs. > Android: run dex with the --force-jumbo switch. > > This is needed to merge dex files collectively containing more than 65536 > strings. More details at > https://code.google.com/p/android/issues/detail?id=40772 and in the bug. > > BUG=272064 > R=andrewhayden@chromium.org > > Review URL: https://codereview.chromium.org/22950006 TBR=ppi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M trunk/src/build/android/gyp/dex.py View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dmazzoni
7 years, 4 months ago (2013-08-13 17:48:58 UTC) #1
dmazzoni
Committed patchset #1 manually as r217286.
7 years, 4 months ago (2013-08-13 17:49:53 UTC) #2
dmazzoni
7 years, 4 months ago (2013-08-13 17:50:32 UTC) #3
Message was sent while issue was closed.
Oops, I see that the first patch set passed try jobs.
I still think this may have caused the failure, though.

Powered by Google App Engine
This is Rietveld 408576698