Android: run dex with the --force-jumbo switch.

Android: run dex with the --force-jumbo switch.

This is needed to merge dex files collectively containing more than 65536
strings. More details at
https://code.google.com/p/android/issues/detail?id=40772 and in the bug.

BUG=272064
R=andrewhayden@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217273

[ppi, 2013-08-13 14:52:34]

Could you guys have a look?

[Andrew Hayden (chromium.org), 2013-08-13 14:56:48]

LGTM

https://codereview.chromium.org/22950006/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/22950006/diff/1/build/android/gyp/dex.py#newc...
build/android/gyp/dex.py:18: dex_cmd = [dx_binary, '--dex', '--force-jumbo',
'--output',
Could we add a comment here with a link back to the crbug in case people are
wondering why we are turning on --force-jumbo? The other flags are all obvious,
but the need for this one isn't clear unless you happen to know the context of
the bug.

[ppi, 2013-08-13 15:05:57]

Thanks, Andrew!

I have added the comment as you suggested.

Unless someone objects very soon, I am going to take the risk and dcommit, to
unblock the autoroller.

https://codereview.chromium.org/22950006/diff/1/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/22950006/diff/1/build/android/gyp/dex.py#newc...
build/android/gyp/dex.py:18: dex_cmd = [dx_binary, '--dex', '--force-jumbo',
'--output',
On 2013/08/13 14:56:48, Andrew Hayden wrote:
> Could we add a comment here with a link back to the crbug in case people are
> wondering why we are turning on --force-jumbo? The other flags are all
obvious,
> but the need for this one isn't clear unless you happen to know the context of
> the bug.

Done.

[ppi, 2013-08-13 16:29:28]

I've run into unexpected problems - my SVN account somehow got messed up and I
cannot dcommit anymore.

The issue should be resolved anytime now, if the patch is not in in a few
minutes I will ask someone to dcommit for me.

[ppi, 2013-08-13 16:31:44]

Committed patchset #2 manually as r217273 (presubmit successful).