remove mismatched delete

Remove mismatched delete.

Use SkAutoTArray to create an array and delete it safely.

BUG=https://code.google.com/p/skia/issues/detail?id=1547
R=bungeman@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10925

[bungeman-skia, 2013-08-22 14:59:30]

https://codereview.chromium.org/23068033/diff/1/src/utils/debugger/SkObjectPa...
File src/utils/debugger/SkObjectParser.cpp (right):

https://codereview.chromium.org/23068033/diff/1/src/utils/debugger/SkObjectPa...
src/utils/debugger/SkObjectParser.cpp:339: char* utf8 = new char[sizeNeeded];
suppose this should then be one of SkNEW_ARRAY, SkAutoTDeleteArray,
SkAutoTMalloc, or perhaps better use SkAutoSTMalloc<???>.

[scroggo, 2013-08-22 15:43:59]

https://codereview.chromium.org/23068033/diff/1/src/utils/debugger/SkObjectPa...
File src/utils/debugger/SkObjectParser.cpp (right):

https://codereview.chromium.org/23068033/diff/1/src/utils/debugger/SkObjectPa...
src/utils/debugger/SkObjectParser.cpp:339: char* utf8 = new char[sizeNeeded];
On 2013/08/22 14:59:30, bungeman1 wrote:
> suppose this should then be one of SkNEW_ARRAY, SkAutoTDeleteArray,
> SkAutoTMalloc, or perhaps better use SkAutoSTMalloc<???>.

Done.

[bungeman-skia, 2013-08-22 20:03:09]

https://codereview.chromium.org/23068033/diff/6001/src/utils/debugger/SkObjec...
File src/utils/debugger/SkObjectParser.cpp (right):

https://codereview.chromium.org/23068033/diff/6001/src/utils/debugger/SkObjec...
src/utils/debugger/SkObjectParser.cpp:340: char* utf8 = autoArray.get();
I like

SkAutoSTMalloc<0x100, char> utf8(sizeNeeded);

Using the array makes it seem like we're going to use it 'array like', but we're
really just getting a hunk of memory. Most text runs are pretty short, so they
should mostly fit on the stack. Also, this way there's an implicit conversion to
T*, so we don't need another name (autoArray).

[scroggo, 2013-08-26 20:31:27]

On 2013/08/22 20:03:09, bungeman1 wrote:
>
https://codereview.chromium.org/23068033/diff/6001/src/utils/debugger/SkObjec...
> File src/utils/debugger/SkObjectParser.cpp (right):
> 
>
https://codereview.chromium.org/23068033/diff/6001/src/utils/debugger/SkObjec...
> src/utils/debugger/SkObjectParser.cpp:340: char* utf8 = autoArray.get();
> I like
> 
> SkAutoSTMalloc<0x100, char> utf8(sizeNeeded);
> 
> Using the array makes it seem like we're going to use it 'array like', but
we're
> really just getting a hunk of memory. Most text runs are pretty short, so they
> should mostly fit on the stack. Also, this way there's an implicit conversion
to
> T*, so we don't need another name (autoArray).

Done.

[bungeman-skia, 2013-08-26 21:18:41]

lgtm

[scroggo, 2013-08-26 21:20:29]

Committed patchset #3 manually as r10925 (presubmit successful).