remove mismatched delete

src/utils/debugger/SkObjectParser.cpp

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkObjectParser.h"
 #include "SkData.h"
@@ skipping 318 matching lines @@
     SkString* decodedText = new SkString();
     switch (encoding) {
         case SkPaint::kUTF8_TextEncoding: {
             decodedText->append("UTF-8: ");
             decodedText->append((const char*)text, byteLength);
             break;
         }
         case SkPaint::kUTF16_TextEncoding: {
             decodedText->append("UTF-16: ");
             size_t sizeNeeded = SkUTF16_ToUTF8((uint16_t*)text, byteLength / 2, NULL);
-            char* utf8 = new char[sizeNeeded];
+            SkAutoTArray<char> autoArray(sizeNeeded);
+            char* utf8 = autoArray.get();

[bungeman-skia, 2013/08/22 20:03:09]

I like

SkAutoSTMalloc<0x100, char> utf8(sizeNeeded);

Using the array makes it seem like we're going to use it 'array like', but we're
really just getting a hunk of memory. Most text runs are pretty short, so they
should mostly fit on the stack. Also, this way there's an implicit conversion to
T*, so we don't need another name (autoArray).

             SkUTF16_ToUTF8((uint16_t*)text, byteLength / 2, utf8);
             decodedText->append(utf8, sizeNeeded);
-            delete utf8;
             break;
         }
         case SkPaint::kUTF32_TextEncoding: {
             decodedText->append("UTF-32: ");
             const SkUnichar* begin = (const SkUnichar*)text;
             const SkUnichar* end = (const SkUnichar*)((const char*)text + byteLength);
             for (const SkUnichar* unichar = begin; unichar < end; ++unichar) {
                 decodedText->appendUnichar(*unichar);
             }
             break;
         }
         case SkPaint::kGlyphID_TextEncoding: {
             decodedText->append("GlyphID: ");
             const uint16_t* begin = (const uint16_t*)text;
             const uint16_t* end = (const uint16_t*)((const char*)text + byteLength);
             for (const uint16_t* glyph = begin; glyph < end; ++glyph) {
                 decodedText->append("0x");
                 decodedText->appendHex(*glyph);
                 decodedText->append(" ");
             }
             break;
         }
         default:
             decodedText->append("Unknown text encoding.");
             break;
     }
 
     return decodedText;
 }