src/utils/debugger/SkObjectParser.cpp - Issue 23068033: remove mismatched delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/debugger/SkObjectParser.cpp

Issue 23068033: remove mismatched delete (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Respond to comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/debugger/SkObjectParser.cpp

diff --git a/src/utils/debugger/SkObjectParser.cpp b/src/utils/debugger/SkObjectParser.cpp

index 504cd085c92fc38ad8924c24370ed4dd6879df95..9dd77c0d7322794a8e10e4549209f12291792ac6 100644

--- a/src/utils/debugger/SkObjectParser.cpp

+++ b/src/utils/debugger/SkObjectParser.cpp

@@ -336,10 +336,9 @@ SkString* SkObjectParser::TextToString(const void* text, size_t byteLength,

case SkPaint::kUTF16_TextEncoding: {

decodedText->append("UTF-16: ");

size_t sizeNeeded = SkUTF16_ToUTF8((uint16_t*)text, byteLength / 2, NULL);

- char* utf8 = new char[sizeNeeded];

+ SkAutoSTMalloc<0x100, char> utf8(sizeNeeded);

SkUTF16_ToUTF8((uint16_t*)text, byteLength / 2, utf8);

decodedText->append(utf8, sizeNeeded);

- delete utf8;

break;

}

case SkPaint::kUTF32_TextEncoding: {

« no previous file with comments | « no previous file | no next file » | no next file with comments »